Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fo go modules #329

Open
badrabubker opened this issue Mar 27, 2020 · 0 comments
Open

Support fo go modules #329

badrabubker opened this issue Mar 27, 2020 · 0 comments

Comments

@badrabubker
Copy link

Hi,
thanks for providing elasticsearch-exporter. I was trying to package this exporter for debian.

First issue i had is that prometheus-client-golang in the vendor directory is outdated and newer versions break computability with the < 1 versions .
So i patched that in the package.
I tired to vendor it as well, however the newer prometheus-client-golang depends on github.com/cespare/xxhash/v2 which needs go modules

I would be happy to submit a pull request if you would like :)

Thanks !
Cheers,
Badr

sysadmind added a commit to sysadmind/elasticsearch_exporter that referenced this issue Apr 7, 2020
This should address prometheus-community#329 including the update to the prometheus/client_golang dependency to a version that supports go modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant