Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prematurely indexing documents into the persistent index store #1238

Closed
jarohen opened this issue Nov 9, 2020 · 0 comments · Fixed by #1240
Closed

Prematurely indexing documents into the persistent index store #1238

jarohen opened this issue Nov 9, 2020 · 0 comments · Fixed by #1240
Assignees
Labels
1.x bug Something isn't working
Milestone

Comments

@jarohen
Copy link
Member

jarohen commented Nov 9, 2020

https://github.com/juxt/crux/blob/143011256caf7fa7ffbfd24e69efd67d0c09ae85/crux-core/src/crux/tx.clj#L302 indexes documents into the persistent index store, even though we could later abort the transaction, or we may even be in a forked transaction.

If the transaction does go on to abort, we still (currently) need the documents indexed into the persistent index store, so that we can later evict them if need be (see #371). In a forked tx, though, we shouldn't save anything to persistent storage.

@jarohen jarohen created this issue from a note in XTDB Development (Backlog) Nov 9, 2020
@jarohen jarohen added the bug Something isn't working label Nov 9, 2020
@jarohen jarohen moved this from Backlog to In progress in XTDB Development Nov 9, 2020
@jarohen jarohen self-assigned this Nov 9, 2020
@jarohen jarohen moved this from In progress to Awaiting merge in XTDB Development Nov 9, 2020
@jarohen jarohen moved this from Awaiting merge to In progress in XTDB Development Nov 9, 2020
@jarohen jarohen moved this from In progress to Awaiting merge in XTDB Development Nov 10, 2020
XTDB Development automation moved this from Awaiting merge to Awaiting release Nov 11, 2020
@jarohen jarohen added this to the 1.13.0 milestone Dec 23, 2020
@jarohen jarohen added the 1.x label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant