#428 - temporarily removing evict valid time ranges #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarohen
force-pushed
the
428-removing-evict-valid-time-ranges
branch
from
0c9c622
to
d66a37f
Compare
jarohen
changed the title
jonpither
approved these changes
Nov 25, 2019
jarohen
force-pushed
the
428-removing-evict-valid-time-ranges
branch
from
d66a37f
to
4fadb5b
Compare
hraberg
approved these changes
Nov 26, 2019
crux-core/src/crux/tx.clj
Outdated
| @@ -96,26 +96,34 @@ | |||
| tx-id) | |||
| (c/->id-buffer new-v)]]})) | |||
|
|
|||
| (defn tx-command-evict [indexer kv object-store snapshot tx-log [op k start-valid-time end-valid-time keep-latest? keep-earliest?] transact-time tx-id] | |||
| (def evict-time-ranges-env-var "CRUX_EVICT_TIME_RANGES") | |||
| (def ^:dynamic evict-all-on-legacy-time-ranges? (= (System/getenv evict-time-ranges-env-var) "EVICT_ALL")) | |||
There was a problem hiding this comment.
If this is dynamic it should have a *evict...* name.
jarohen
force-pushed
the
428-removing-evict-valid-time-ranges
branch
from
3d404a3
to
5a2e725
Compare
jarohen
force-pushed
the
428-removing-evict-valid-time-ranges
branch
from
5a2e725
to
d6c0517
Compare
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the time ranges and boolean flags from the evict tx-op, until we can define a consistent semantics for how they should behave (see #428 for more details and rationale)
N.B.:
CRUX_EVICT_TIME_RANGESenvironment variable toEVICT_ALL, which tells the indexer to ignore the time ranges and evict the document for all valid times. (in fact, the error message points the user to this PR)