Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create reminder" modal is not updated when selecting Channel or Other Users #10

Closed
c0gnize opened this issue Jun 16, 2023 · 4 comments · Fixed by #11
Closed

"Create reminder" modal is not updated when selecting Channel or Other Users #10

c0gnize opened this issue Jun 16, 2023 · 4 comments · Fixed by #11

Comments

@c0gnize
Copy link
Contributor

c0gnize commented Jun 16, 2023

Currently unable to create another user or channel reminder.

I am using 1.0.5 version of reminder, installed locally using zip.

It is related with #3 but without any errors in API
@c0gnize
Copy link
Contributor Author

c0gnize commented Jun 16, 2023

May be helpful. I discovered that after changing viewId value to modal-reminder-create--GENERAL modal updated correctly

Screenshot 2023-06-16 at 11 36 15

@c0gnize
Copy link
Contributor Author

c0gnize commented Jun 16, 2023

Interesting, when calling this.read.getMessageReader().getById(null) instead of undefined it returns non-empty value. I think this is the root of problem

c0gnize added a commit to c0gnize/Rocket.Chat-reminder that referenced this issue Jun 17, 2023
@c0gnize
Fix: show channel input when selecting remind to channel
b154b84 
Closes juzser#10
@c0gnize c0gnize mentioned this issue Jun 17, 2023
Merged
@juzser
Copy link
Owner

juzser commented Jun 19, 2023

Thank you.
Let me merge this.

@juzser juzser closed this as completed Jun 19, 2023
@juzser
Copy link
Owner

juzser commented Jun 19, 2023 •
edited
Loading

Released via v1.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: show channel input when selecting remind to channel c0gnize/Rocket.Chat-reminder
2 participants
@juzser @c0gnize