Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build script for AppImage #15

Closed
juzzlin opened this issue Aug 11, 2018 · 7 comments
Closed

Add build script for AppImage #15

juzzlin opened this issue Aug 11, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@juzzlin
Copy link
Owner

juzzlin commented Aug 11, 2018

https://github.com/AppImage/AppImageKit/wiki/Bundling-Qt-apps

@juzzlin juzzlin added enhancement New feature or request good first issue Good for newcomers labels Aug 11, 2018
@ghost
Copy link

ghost commented Aug 11, 2018

If you need any help just ask @probonopd ;-)

probonopd added a commit to AppImage/appimage.github.io that referenced this issue Aug 12, 2018
Merge only after this has been upstreamed; juzzlin/Heimer#15
@probonopd
Copy link

I have made a test AppImage using https://github.com/probonopd/Heimer/blob/patch-1/.travis.yml.
It is for download at https://github.com/probonopd/Heimer/releases.
Please test it; if it is OK I will send a pull request to this repository. Thanks!

@juzzlin
Copy link
Owner Author

juzzlin commented Aug 12, 2018

Seems to work except for the launcher icon. There's data/icons/heimer.png that's used for Debian packaging. Is it possible to make that work with AppImage also?

@probonopd
Copy link

probonopd commented Aug 14, 2018

Please use QApplication::setWindowIcon() in your code.

@juzzlin
Copy link
Owner Author

juzzlin commented Aug 14, 2018

It's the location of the file in the source tree.

The current configuration installs it to ${CMAKE_INSTALL_PREFIX}/share/icons/hicolor/64x64/apps as you can see in InstallLinux.cmake.

The desktop file already has Icon=heimer and this works for the .deb.

@juzzlin
Copy link
Owner Author

juzzlin commented Aug 14, 2018

Actually QMainWindow::setWindowIcon() was already used, but the icon resource file name was not correct. Thanks for noticing this! It seems that Qt doesn't give any warnings about this..

@probonopd
Copy link

Thank you very much. Looks like this can be closed now, as an AppImage is available on GitHub Releases. Thank you very much!

Reference:
AppImage/appimage.github.io#771

@juzzlin juzzlin closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants