Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Composite Blocktype Validation does not account for different block ordering #497

Closed
georg-schwarz opened this issue Jan 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@georg-schwarz
Copy link
Member

Steps to reproduce

  1. Add an unused block to an existing blocktype definition
  2. Move the unused block up and down

Description

  • Expected: The "unused" warning stays at the unused block
  • Actual: The warning jumps over to other blocks

Notes

  • Issue is probably the validation function that assumes the correct order of blocks instead of navigating over the graph of blocks and pipes (see here)
  • In the same go, the validation logic should be moved to the container (pipeline, composite blocktype) to avoid "going upwards" in the AST as much as possible
@TungstnBallon
Copy link
Contributor

This seems to be fixed, perhaps by a44a73c?

Screencast.from.2024-05-17.12-06-38.webm

@rhazn
Copy link
Contributor

rhazn commented May 17, 2024

I agree, can't reproduce either.

@rhazn rhazn closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants