Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Transformation: Move remaining pipelineConfig to transformation service #53

Closed
mathiaszinnen opened this issue Apr 20, 2020 · 3 comments

Comments

@mathiaszinnen
Copy link
Contributor

mathiaszinnen commented Apr 20, 2020

Currently, configurations for data transformation and notifications are stored and handled at the core service. This task should be handled by the transformation service. The exact implementation is highly dependent on whether we already have rabbitMQ or not. I suggest implementing rabbitMQ first so we do not have to implement event handling twice.

@mathiaszinnen mathiaszinnen created this issue from a note in ODS Development (To do) Apr 20, 2020
@mathiaszinnen
Copy link
Contributor Author

Use node-persist for persistence?

@georg-schwarz
Copy link
Member

So, as I understand it, the library you propose is only in-memory, or at least not sharable with other instances of the same microservice type. I would rather go with a postgres solution.

With the new insights emerging of segregating notification and transformation service, we should also split this task into two issues.

@mathiaszinnen
Copy link
Contributor Author

Agree, I would propose closing this issue and creating new issues after rabbitMQ integration

ODS Development automation moved this from To do to Done May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants