Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 update-link directive not working while update-meta is working... #28

Closed
corvind opened this issue Apr 18, 2017 · 14 comments
Closed

Comments

@corvind
Copy link

corvind commented Apr 18, 2017

Is it only me? Ive spent a good 2 hours trying to get update-link directive to work.

I checked the documentation and examples and have rechecked my code at least 10 times, even had a peek into the release to check the directive was there! (Sadly the plunker hasnt been updated to include any working update-link examples - although i have COPIED the documentation examples into my page and they dont work.)

  1. In my index.php I have the default tags in my head which includes the meta properties as well as the link rels.

  2. In my gallery subpage/subdirectory I have included the update-meta and update-link directives as given in the example.

  3. this results in the meta tags being updated, while the link tags remain as in the 'default' values in the head of the document.

....?!?....

Could somebody please create a working update-link plunker?

@jvandemo
Copy link
Owner

@corvind — Thank you for reporting.

@khisakuni — Would you be able to jump in and give your thoughts on this? Thanks!

@khisakuni
Copy link
Contributor

I can take a look this weekend

@jvandemo
Copy link
Owner

Awesome, thank you, Kohei, much appreciated! 👍

@khisakuni
Copy link
Contributor

Played around with it briefly and it does look like it's busted. I'll look into it further when I get a chance and make a PR with a fix.

@jvandemo
Copy link
Owner

@khisakuni — Thank you, much appreciated! 🏆

@corvind
Copy link
Author

corvind commented May 16, 2017

@khisakuni - would you be able to look at it soon please? :) Its been 4 weeks and I would like to release my website soon and this module is key. Sorry, I hate to be the one that complains about something free; If my angular knowledge was better I would try to contribute but I just started coding and its beyond my level of understanding. Cheers!

@samsole4
Copy link

Hi, I used this workaround, changed this line in the update-link directive
var selector = 'link' + buildQuery(scope, supportedAttributes);
for
var selector = 'link' + buildQuery(scope, queryAttributes);
and worked for me.

@jvandemo
Copy link
Owner

@khisakuni — Were you able to have a look at it already? Thanks!

@jvandemo
Copy link
Owner

@corvind — If @khisakuni doesn't have a chance to look at it, I will have a look at it tomorrow morning 👍

@khisakuni
Copy link
Contributor

Hey @corvind, sorry I haven't had a chance to take another look at it. I should be able to take a look tonight. Thanks for your patience

@jvandemo
Copy link
Owner

@khisakuni — Awesome; thank you for your follow-up! 👍

@jvandemo
Copy link
Owner

@corvind — A fix has been released as v2.0.1. Can you please install the latest version and let us know if everything works as expected? Feel free to re-open this issue if you still experience problems. Thanks!

Thank you @samsole4 and @khisakuni for your efforts, much appreciated! 👍

@corvind
Copy link
Author

corvind commented May 26, 2017

@jvandemo and @khisakuni and @samsole4 - Thanks a lot for your efforts. Everything I coded worked as expected from the start :) hahaha =D

@jvandemo
Copy link
Owner

@corvind — Awesome, thank you for the confirmation. Much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants