-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 update-link directive not working while update-meta is working... #28
Comments
@corvind — Thank you for reporting. @khisakuni — Would you be able to jump in and give your thoughts on this? Thanks! |
I can take a look this weekend |
Awesome, thank you, Kohei, much appreciated! 👍 |
Played around with it briefly and it does look like it's busted. I'll look into it further when I get a chance and make a PR with a fix. |
@khisakuni — Thank you, much appreciated! 🏆 |
@khisakuni - would you be able to look at it soon please? :) Its been 4 weeks and I would like to release my website soon and this module is key. Sorry, I hate to be the one that complains about something free; If my angular knowledge was better I would try to contribute but I just started coding and its beyond my level of understanding. Cheers! |
Hi, I used this workaround, changed this line in the update-link directive |
@khisakuni — Were you able to have a look at it already? Thanks! |
@corvind — If @khisakuni doesn't have a chance to look at it, I will have a look at it tomorrow morning 👍 |
Hey @corvind, sorry I haven't had a chance to take another look at it. I should be able to take a look tonight. Thanks for your patience |
@khisakuni — Awesome; thank you for your follow-up! 👍 |
@corvind — A fix has been released as v2.0.1. Can you please install the latest version and let us know if everything works as expected? Feel free to re-open this issue if you still experience problems. Thanks! Thank you @samsole4 and @khisakuni for your efforts, much appreciated! 👍 |
@jvandemo and @khisakuni and @samsole4 - Thanks a lot for your efforts. Everything I coded worked as expected from the start :) hahaha =D |
@corvind — Awesome, thank you for the confirmation. Much appreciated! 👍 |
Is it only me? Ive spent a good 2 hours trying to get update-link directive to work.
I checked the documentation and examples and have rechecked my code at least 10 times, even had a peek into the release to check the directive was there! (Sadly the plunker hasnt been updated to include any working update-link examples - although i have COPIED the documentation examples into my page and they dont work.)
In my index.php I have the default tags in my head which includes the meta properties as well as the link rels.
In my gallery subpage/subdirectory I have included the update-meta and update-link directives as given in the example.
this results in the meta tags being updated, while the link tags remain as in the 'default' values in the head of the document.
....?!?....
Could somebody please create a working update-link plunker?
The text was updated successfully, but these errors were encountered: