Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntheticSpectrum test keeps failing #43

Closed
cylammarco opened this issue Jun 24, 2021 · 2 comments
Closed

SyntheticSpectrum test keeps failing #43

cylammarco opened this issue Jun 24, 2021 · 2 comments
Assignees
@jveitchmichaelis
Labels
bug Something isn't working urgent
Projects
v0.3.0
Milestone
V0.3.0

Comments

@cylammarco
Copy link
Collaborator

Need to investigate whether the generation of a synthetic spectrum is erroneous, the test is or the wavelength calibration is.
@cylammarco cylammarco added bug Something isn't working urgent labels Jun 24, 2021
@cylammarco cylammarco added this to the V0.3.0 milestone Jun 24, 2021
@cylammarco cylammarco added this to To do in v0.3.0 via automation Jun 24, 2021
@cylammarco
Copy link
Collaborator Author

I am currently setting the peak_utilisation acceptance value to 0.1 and rms to less than 5. More investigation is needed.

@cylammarco
Copy link
Collaborator Author

Fixed by @jveitchmichaelis in 595644a.

@cylammarco cylammarco moved this from To do to Done in v0.3.0 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jveitchmichaelis jveitchmichaelis

Labels
bug Something isn't working urgent
Projects
No open projects
v0.3.0
  
Done
Milestone
V0.3.0
Development

No branches or pull requests
2 participants
@cylammarco @jveitchmichaelis