Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UITextView Equivalent #28

Closed
thomasconner opened this issue Nov 18, 2013 · 6 comments
Closed

Create UITextView Equivalent #28

thomasconner opened this issue Nov 18, 2013 · 6 comments

Comments

@thomasconner
Copy link

I would appreciate it if you added a UITextView equivalent for this control. I have tried using RPFloatingPlaceholderTextView but it has several displaying issues. I believe this should be simple for you to port over to a UITextView. Thanks!

@jverdi
Copy link
Owner

jverdi commented Nov 19, 2013

Ok. I just pushed a commit with a first pass of JVFloatLabeledTextView. Let me know how it works out for you.

@odanu
Copy link

odanu commented Nov 19, 2013

When would it be released?

@thomasconner
Copy link
Author

ios simulator screen shot nov 19 2013 8 44 28 am

The leading padding for the text view is off compared to the text field. The floating label works well for the text view otherwise.

@jverdi
Copy link
Owner

jverdi commented Nov 19, 2013

Check the demo project for one way that you can position the UITextView to match the text field's left edge. All UITextView's layout text with some default padding, and I don't want to modify this UITextView's behavior to act differently than Apple's in that regard.

On Nov 19, 2013, at 8:47 AM, Thomas Conner notifications@github.com wrote:

The leading padding for the text view is off compared to the text field and the floating label is a little hight above the text in the text view then the text field. I actually like the distance between the text and the floating label in the text view more then that of the text field. Anyways, great work. I hope this helps fix these few minor issues. The floating label works well for the text view otherwise.


Reply to this email directly or view it on GitHub.

@thomasconner
Copy link
Author

Ok I will. I wasn't aware this was something core to the UITextView and I agree that you should not change it. Thanks.

@thomasconner
Copy link
Author

Works great! Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants