Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of file_browser from Telescope builtin #12

Open
axieax opened this issue May 4, 2022 · 4 comments · May be fixed by #19
Open

Removal of file_browser from Telescope builtin #12

axieax opened this issue May 4, 2022 · 4 comments · May be fixed by #19
Labels
bug Something isn't working help wanted Extra attention is needed reproducible Issues than I can reproduce myself

Comments

@axieax
Copy link

axieax commented May 4, 2022

Seems like Telescope file_browser was removed as a builtin a while ago. I've been using a custom mapping in my config to use the correct file_browser, but think it'll be nice to update the plugin so it works out of the box. I'm happy to make PR if you want, but just wanted to make sure you're cool with having https://github.com/nvim-telescope/telescope-file-browser.nvim as an extra dependency now.

Relevant change:

nvim-telescope/telescope.nvim#1470 (comment)

@jvgrootveld jvgrootveld added bug Something isn't working reproducible Issues than I can reproduce myself labels Sep 12, 2022
@jvgrootveld
Copy link
Owner

@axieax good find! I don't use this feature myself a lot so didn't walked against this issue yet.

I added this in the default config because the feature was already available out of the box. I don't think it is necessary to add an extra dependency for all users, regarding if they use it. I think we should remove this from the default config and let users choose if they want to add.

I will make the change later and add some documentation in the release how to add it back if wanted.

@jvgrootveld
Copy link
Owner

@axieax I'm sorry, I found little time with my newborn daughter to implement this as discussed. It would be awesome if you could help with a PR.

@jvgrootveld jvgrootveld added the help wanted Extra attention is needed label Feb 8, 2023
@axieax
Copy link
Author

axieax commented Feb 11, 2023

Oh congratulations, that's very exciting news!! 🎉🎉
I've create a PR for this in #19 :))

@axieax axieax linked a pull request Feb 11, 2023 that will close this issue
2 tasks
@eXvimmer
Copy link

I've added this to the config and it works fine

mappings = {
["<C-b>"] = {
  action = function(selection)
    vim.cmd("Telescope file_browser path=" .. selection.path .. " select_buffer=true")
  end,
  after_action = function(selection)
    vim.notify("Directory changed to " .. selection.path)
  end,
},
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed reproducible Issues than I can reproduce myself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants