Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ACTORS> data missing from "sort.metadata.nfo.displayname" if scraped actor name is in Japanese #103

Closed
org0ne opened this issue Sep 22, 2020 · 2 comments · Fixed by #114
Assignees
Labels
bug Something isn't working
Projects

Comments

@org0ne
Copy link

org0ne commented Sep 22, 2020

Expected Behavior

jvThumbs.csv actor name should propagate to all fields

Current Behavior

When scraping a title where the results are only in Japanese, the Folder name and and tags are correctly written, but the filed inside of "sort.metadata.nfo.displayname" will be blank

Steps to Reproduce (for bugs)

  • use the attached jvSettings.json (mostly just to use my custom regex to capture the ID)
    jvSettings.txt

  • scrape 010507_033.mp4

  • review the outputted nfo file

Your Environment

  • Module version used: 2.0.1
  • Operating System and PowerShell version: Ubuntu 18.04, powershell 7.0.3
@org0ne
Copy link
Author

org0ne commented Sep 22, 2020

FYI - Just tested this on 2.0.2 and see the same behavior

@jvlflame jvlflame added the bug Something isn't working label Sep 22, 2020
@jvlflame
Copy link
Collaborator

I added logic to make it fallback to the non-selected actress language for all format names with <ACTOR> in it when the primary language name isn't available.

@jvlflame jvlflame self-assigned this Sep 23, 2020
@jvlflame jvlflame added this to Done in 2.1.0 Sep 23, 2020
@jvlflame jvlflame mentioned this issue Sep 30, 2020
@jvlflame jvlflame linked a pull request Sep 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
2.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants