Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: use "unknown" for unknown actors #105

Closed
org0ne opened this issue Sep 22, 2020 · 1 comment · Fixed by #114
Closed

Feature Request: use "unknown" for unknown actors #105

org0ne opened this issue Sep 22, 2020 · 1 comment · Fixed by #114
Assignees
Labels
enhancement New feature or request
Projects

Comments

@org0ne
Copy link

org0ne commented Sep 22, 2020

Releases often have unknown actors upon release, especially for smaller studios. I have typically used "unknown" as the actor name so that I can easily find all movies that do not yet have an actor name and then search http://sougouwiki.com periodically to see if someone has identified the actress.

Currently Javinizer just leaves the actor blank. While it is possible, searching for the "lack" of information is more difficult than using explicit searches.

@jvlflame jvlflame added the enhancement New feature or request label Sep 22, 2020
@jvlflame jvlflame self-assigned this Sep 23, 2020
@jvlflame jvlflame added this to Done in 2.1.0 Sep 23, 2020
@jvlflame
Copy link
Collaborator

jvlflame commented Sep 24, 2020

Writing this out here just so it's documented:

New boolean setting sort.metadata.nfo.unknownactress added to add an "Unknown" actress to the aggregated data object if no actresses are available following the scrape.

The actress object will be output as follows, adding the name as 'Unknown' no matter what actress language preference is selected:

$aggregatedDataObject.Actress += [PSCustomObject]@{
    LastName     = $null
    FirstName    = 'Unknown'
    JapaneseName = 'Unknown'
    ThumbUrl     = $null
}

@jvlflame jvlflame mentioned this issue Sep 30, 2020
@jvlflame jvlflame linked a pull request Sep 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
2.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants