Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert-JVString() failed to return proper Japanese Actress Name (with solution) #167

Closed
amdishigh opened this issue Dec 24, 2020 · 1 comment · Fixed by #170
Closed
Assignees
Labels
bug Something isn't working

Comments

@amdishigh
Copy link

Expected Behavior

Convert-JVString() should return Japanese Actress Name When ActressLanguageJa = $True

Current Behavior

Convert-JVSring() return English Actress Name instead

Steps to Reproduce (for bugs)

Your Environment

  • Module version used: 2.2.2
  • Operating System and PowerShell version:

##Solution
Line 92 of Convert-JVString.ps1 should be changed from:
$actressObject = $Data.Actress.Japanese
To:
$actressObject = $Data.Actress.JapaneseName

@jvlflame jvlflame self-assigned this Dec 24, 2020
@jvlflame jvlflame added the bug Something isn't working label Dec 24, 2020
@jvlflame
Copy link
Collaborator

Thanks for reporting this! I will fix it for the next release.

@jvlflame jvlflame linked a pull request Dec 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants