Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identical names in every .nfo file when using DMM scraper #92

Closed
ozawaslave opened this issue Sep 19, 2020 · 7 comments · Fixed by #95
Closed

Identical names in every .nfo file when using DMM scraper #92

ozawaslave opened this issue Sep 19, 2020 · 7 comments · Fixed by #95
Assignees
Labels
bug Something isn't working

Comments

@ozawaslave
Copy link

ozawaslave commented Sep 19, 2020

Expected Behavior

I prefer to organize using japanese names. Previous version allowed me to do this. Expected behavior is for every .nfo generated from a movie ID to have actress names in Japanese. Though I see alternative names are support, so I am fine if they're all in English, and have alternate names in japanese.

Current Behavior

Every .nfo file has the 6 same actresses. and they all start with:

In IPX-524:

  <actor>
    <name>Ishihara Nozomi</name>
    <role>Actress</role>
    <type>Actor</type>
  </actor>
  <actor>
    <name>Fukada Eimi</name>
    <role>Actress</role>
    <type>Actor</type>
    <thumb>**********</thumb>
  </actor>
  <actor>
    <name>Neo Akari</name>
    <role>Actress</role>
    <type>Actor</type>
    <thumb>**********</thumb>
  </actor>
  <actor>
    <name>Fujimori Riho</name>
    <role>Actress</role>
    <type>Actor</type>
  </actor>
  <actor>
    <name>Yumeno Aika</name>
    <role>Actress</role>
    <type>Actor</type>
    <thumb>**********</thumb>
  </actor>
  <actor>
    <name>Kami Anna</name>
    <role>Actress</role>
    <type>Actor</type>
  </actor>

In IPX-543:

  <actor>
    <name>Ishihara Nozomi</name>
    <role>Actress</role>
    <type>Actor</type>
  </actor>
  <actor>
    <name>Fukada Eimi</name>
    <role>Actress</role>
    <type>Actor</type>
    <thumb>**********</thumb>
  </actor>
  <actor>
    <name>Neo Akari</name>
    <role>Actress</role>
    <type>Actor</type>
    <thumb>**********</thumb>
  </actor>
  <actor>
    <name>Fujimori Riho</name>
    <role>Actress</role>
    <type>Actor</type>
  </actor>
  <actor>
    <name>Yumeno Aika</name>
    <role>Actress</role>
    <type>Actor</type>
    <thumb>**********</thumb>
  </actor>
  <actor>
    <name>Kami Anna</name>
    <role>Actress</role>
    <type>Actor</type>
  </actor>

Steps to Reproduce (for bugs)

jvSettings.json
{
    "throttlelimit": 3,
    "location.input": "****************"
    "location.output": "****************",
    "location.thumbcsv": "",
    "location.genrecsv": "",
    "location.log": "",
    "scraper.movie.dmm": true,
    "scraper.movie.dmmja": true,
    "scraper.movie.jav321ja": false,
    "scraper.movie.javbus": false,
    "scraper.movie.javbusja": true,
    "scraper.movie.javbuszh": false,
    "scraper.movie.javlibrary": true,
    "scraper.movie.javlibraryja": true,
    "scraper.movie.javlibraryzh": false,
    "scraper.movie.r18": true,
    "scraper.movie.r18zh": false,
    "scraper.option.dmm.scrapeactress": true,
    "match.minimumfilesize": 0,
    "match.includedfileextension": [
        ".asf",
        ".avi",
        ".flv",
        ".m4v",
        ".mkv",
        ".mp4",
        ".mov",
        ".rmvb",
        ".wmv"
    ],
    "match.excludedfilestring": ["^.*-trailer*", "^.*-5\\."],
    "match.regex": 0,
    "match.regex.string": "([a-zA-Z|tT28]+-\\d+z{0,1}Z{0,1}e{0,1}E{0,1})(?:-pt){0,1}(\\d{1,2})?",
    "match.regex.idmatch": 1,
    "match.regex.ptmatch": 2,
    "sort.movetofolder": 1,
    "sort.renamefile": 1,
    "sort.maxtitlelength": 100,
    "sort.create.nfo": true,
    "sort.create.nfoperfile": true,
    "sort.download.actressimg": true,
    "sort.download.thumbimg": 1,
    "sort.download.posterimg": 1,
    "sort.download.screenshotimg": 0,
    "sort.download.trailervid": 0,
    "sort.format.delimiter": ", ",
    "sort.format.file": "<ID>",
    "sort.format.folder": "<ID> [<STUDIO>] - <TITLE> (<YEAR>)",
    "sort.format.posterimg": ["folder"],
    "sort.format.thumbimg": "fanart",
    "sort.format.trailervid": "<ID>-trailer",
    "sort.format.nfo": "<ID>",
    "sort.format.screenshotimg": "fanart",
    "sort.format.screenshotfolder": "extrafanart",
    "sort.format.actressimgfolder": ".actors",
    "sort.metadata.nfo.translatedescription": false,
    "sort.metadata.nfo.translatedescription.language": "en",
    "sort.metadata.nfo.displayname": "[<ID>] <TITLE>",
    "sort.metadata.nfo.seriesastag": true,
    "sort.metadata.nfo.firstnameorder": false,
    "sort.metadata.nfo.actresslanguageja": false,
    "sort.metadata.thumbcsv": true,
    "sort.metadata.thumbcsv.autoadd": true,
    "sort.metadata.thumbcsv.convertalias": true,
    "sort.metadata.genrecsv": true,
    "sort.metadata.genre.ignore": ["^Featured Actress", "^Hi-Def", ".*sale.*"],
    "sort.metadata.requiredfield": ["id", "coverurl", "genre", "maker", "releaseDate", "title"],
    "sort.metadata.priority.actress": ["dmmja", "javlibraryja"],
    "sort.metadata.priority.alternatetitle": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.coverurl": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.description": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.director": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.genre": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.id": ["javlibraryja", "javlibrary", "javbusja", "dmmja", "dmm", "r18"],
    "sort.metadata.priority.label": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.maker": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.releasedate": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.rating": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.runtime": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.series": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.screenshoturl": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.title": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.trailerurl": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "emby.url": "http:\/\/localhost:8096",
    "emby.apikey": "****************",
    "javlibrary.baseurl": "http:\/\/www.javlibrary.com",
    "admin.log": 1,
    "admin.log.level": "info"
}

Your Environment

  • Module version used: 2.0.0
  • Operating System and PowerShell version: MacOS Mojave 10.14.6, PowerShell 7.0.3
@jvlflame
Copy link
Collaborator

I added a new logic in 2.0.0 to always prefer an actress language regardless of the scraper.
If you want to use Japanese actress names, set "sort.metadata.nfo.actresslanguageja": true,.

@jvlflame jvlflame self-assigned this Sep 19, 2020
@jvlflame
Copy link
Collaborator

Actually, both dmm and dmmja scrapers are bugged in 2.0.0.

I currently have fixes in my dev branch e51bd8a a82530d that I'll release this weekend.

@jvlflame jvlflame added the bug Something isn't working label Sep 19, 2020
@jvlflame jvlflame changed the title Identical names in every .nfo file Identical names in every .nfo file when using DMM scraper Sep 19, 2020
@ozawaslave
Copy link
Author

ozawaslave commented Sep 20, 2020

Ok, I updated the two lines in Scraper.Dmm.ps1 from your dev branch on my local machine and it pulls the the first correct actress name and puts them in the .nfo file. If there is more than one than those don't get added. Tested on multi-actress IPX-219 (出演者: 橋本ありな 相沢みなみ 山岸逢花)
Actress(es): Arina Hashimoto Minami Aizawa Aika Yamagishi
https://www.dmm.co.jp/digital/videoa/-/detail/=/cid=ipx00219
https://www.r18.com/videos/vod/movies/detail/-/id=ipx00219

Per your suggestion to get japanese names as the primary names, updated: "sort.metadata.nfo.actresslanguageja": true". Unfortunately, it still puts the japanese name as an alt name, and english as the primary name per the below .nfo example. Honestly not a big deal.

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<movie>
    <title>[IPX-219] BEAUTY VENUS 5</title>
    <originaltitle>BEAUTY VENUS 5</originaltitle>
    <id>IPX-219</id>
    <releasedate>2018-10-12</releasedate>
    <year>2018</year>
    <director>うさぴょん。</director>
    <studio>エスワンナンバーワンスタイル</studio>
    <rating>8</rating>
    <votes>80</votes>
    <plot>AV業界3大美女メーカー・夢の共演!トリプル女神v.s男は常に1名のハーレム痴女作品!女神同士もレズキスたっぷりの圧倒的コンビネーションで交わる!美神ハーレムフェラ・バイノーラル痴女SEX・挑発的レズキスSEX・W潮吹き女教師SEX・身動き封殺SEX・連射抜きハーレムSEXの5本番!女神の皮を被った性獣達、SEXへの執着心はシリーズ最高傑作!</plot>
    <runtime>242</runtime>
    <trailer>https://awscc3001.r18.com/litevideo/freepv/i/ipx/ipx00219/ipx00219_dmb_w.mp4</trailer>
    <mpaa>XXX</mpaa>
    <set>マジックミラー号</set>
    <tag>マジックミラー号</tag>
    <genre>ハイビジョン</genre>
    <genre>独占配信</genre>
    <genre>痴女</genre>
    <genre>乱交</genre>
    <genre>お姉さん</genre>
    <genre>3P・4P</genre>
    <genre>デジモ</genre>
    <actor>
        <name>Hashimoto Arina</name>
        <altname>橋本ありな</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/hasimoto_arina.jpg</thumb>
        <role>Actress</role>
    </actor>
</movie>

jvlflame added a commit that referenced this issue Sep 20, 2020
@jvlflame
Copy link
Collaborator

Good callout on the Dmm actresses. It was bugged, only pulling the first actress, but is now fixed on dev.

Though, sort.metadata.nfo.actresslanguageja: 1 should work.

Here's the expected output:

PS C:\> Javinizer -Find IPX-219 -DmmJa -R18 -Aggregated -Nfo
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<movie>
    <title>[IPX-219] BEAUTY VENUS 5</title>
    <originaltitle>BEAUTY VENUS 5</originaltitle>
    <id>IPX-219</id>
    <releasedate>2018-10-12</releasedate>
    <year>2018</year>
    <director>Usa-pyon.</director>
    <studio>Idea Pocket</studio>
    <rating>8</rating>
    <votes>80</votes>
    <plot>AV業界3大美女メーカー・夢の共演!トリプル女神v.s男は常に1名のハーレム痴女作品!女神同士もレズキスたっぷりの圧倒的コンビネーションで交わる!美神ハーレムフェラ・バイノーラル痴女SEX・挑発的レズキスSEX・W潮吹き女教師SEX・身動き封殺SEX・連射抜きハーレムSEXの5本番!女神の皮を被った性獣達、SEXへの執着心はシリーズ最高傑作!</plot>
    <runtime>242</runtime>
    <trailer>https://awscc3001.r18.com/litevideo/freepv/i/ipx/ipx00219/ipx00219_dmb_w.mp4</trailer>
    <mpaa>XXX</mpaa>
    <set>BEAUTY VENUS</set>
    <tag>BEAUTY VENUS</tag>
    <genre>Slut</genre>
    <genre>Older Sister</genre>
    <genre>Orgy</genre>
    <genre>Threesome - Foursome</genre>
    <genre>Digital Mosaic</genre>
    <actor>
        <name>橋本ありな</name>
        <altname>橋本ありな</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/hasimoto_arina.jpg</thumb>
        <role>Actress</role>
    </actor>
    <actor>
        <name>相沢みなみ</name>
        <altname>相沢みなみ</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/aizawa_minami.jpg</thumb>
        <role>Actress</role>
    </actor>
    <actor>
        <name>山岸逢花</name>
        <altname>山岸逢花</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/yamagishi_aika.jpg</thumb>
        <role>Actress</role>
    </actor>
</movie>

@ozawaslave
Copy link
Author

Expected Behavior

> Javinizer -Find IPX-219 -DmmJa -R18 -Aggregated -Nfo                                                                       <?xml version="1.0" encoding="UTF-8" standalone="yes"?>                                                                                                                                             <movie>                                                                                                                                                                                                       <title>[ipx00219] BEAUTY VENUS 5</title>                                                                                                                                                                  <originaltitle>BEAUTY VENUS 5</originaltitle>                                                                                                                                                             <id>ipx00219</id>                                                                                                                                                     
    <releasedate>2018-10-12</releasedate>
    <year>2018</year>
    <director>うさぴょん。</director>
    <studio>エスワンナンバーワンスタイル</studio>
    <rating>8</rating>
    <votes>80</votes>
    <plot>AV業界3大美女メーカー・夢の共演!トリプル女神v.s男は常に1名のハーレム痴女作品!女神同士もレズキスたっぷりの圧倒的コンビネーションで交わる!美神ハーレムフェラ・バイノーラル痴女SEX・挑発的レズキスSEX・W潮吹き女教師SEX・身動き封殺SEX・連射抜きハーレムSEXの5本番!女神の皮を被った性獣達、SEXへの執着心はシリーズ最高傑作!</plot>
    <runtime>242</runtime>
    <trailer>https://awscc3001.r18.com/litevideo/freepv/i/ipx/ipx00219/ipx00219_dmb_w.mp4</trailer>
    <mpaa>XXX</mpaa>
    <set>【※異常なる大絶頂】</set>
    <tag>【※異常なる大絶頂】</tag>
    <genre>ハイビジョン</genre>
    <genre>独占配信</genre>
    <genre>痴女</genre>
    <genre>乱交</genre>
    <genre>お姉さん</genre>
    <genre>3P・4P</genre>
    <genre>デジモ</genre>
    <actor>
        <name>橋本ありな</name>
        <altname>橋本ありな</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/hasimoto_arina.jpg</thumb>
        <role>Actress</role>
    </actor>
    <actor>
        <name>相沢みなみ</name>
        <altname>相沢みなみ</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/aizawa_minami.jpg</thumb>
        <role>Actress</role>
    </actor>
    <actor>
        <name>山岸逢花</name>
        <altname>山岸逢花</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/yamagishi_aika.jpg</thumb>
        <role>Actress</role>
    </actor>
</movie>

Current Behavior

So if I run the above command, that is indeed the output I get. If I run javinizer by itself with no arguments and rely on the JvSettings json file, then I get something different.

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<movie>
    <title>[IPX-219] BEAUTY VENUS 5</title>
    <originaltitle>BEAUTY VENUS 5</originaltitle>
    <id>IPX-219</id>
    <releasedate>2018-10-12</releasedate>
    <year>2018</year>
    <director>うさぴょん。</director>
    <studio>エスワンナンバーワンスタイル</studio>
    <rating>8</rating>
    <votes>80</votes>
    <plot>AV業界3大美女メーカー・夢の共演!トリプル女神v.s男は常に1名のハーレム痴女作品!女神同士もレズキスたっぷりの圧倒的コンビネーションで交わる!美神ハーレムフェラ・バイノーラル痴女SEX・挑発的レズキスSEX・W潮吹き女教師SEX・身動き封殺SEX・連射抜きハーレムSEXの5本番!女神の皮を被った性獣達、SEXへの執着心はシリーズ最高傑作!</plot>
    <runtime>242</runtime>
    <trailer>https://awscc3001.r18.com/litevideo/freepv/i/ipx/ipx00219/ipx00219_dmb_w.mp4</trailer>
    <mpaa>XXX</mpaa>
    <set>【※異常なる大絶頂】</set>
    <tag>【※異常なる大絶頂】</tag>
    <genre>ハイビジョン</genre>
    <genre>独占配信</genre>
    <genre>痴女</genre>
    <genre>乱交</genre>
    <genre>お姉さん</genre>
    <genre>3P・4P</genre>
    <genre>デジモ</genre>
    <actor>
        <name>Hashimoto Arina</name>
        <altname>橋本ありな</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/hasimoto_arina.jpg</thumb>
        <role>Actress</role>
    </actor>
    <actor>
        <name>Aizawa Minami</name>
        <altname>相沢みなみ</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/aizawa_minami.jpg</thumb>
        <role>Actress</role>
    </actor>
    <actor>
        <name>Yamagishi Aika</name>
        <altname>山岸逢花</altname>
        <thumb>https://pics.r18.com/mono/actjpgs/yamagishi_aika.jpg</thumb>
        <role>Actress</role>
    </actor>
</movie>

My current settings

{
    "throttlelimit": 3,
    "location.input": "***",
    "location.output": "***",
    "location.thumbcsv": "",
    "location.genrecsv": "",
    "location.log": "",
    "scraper.movie.dmm": true,
    "scraper.movie.dmmja": true,
    "scraper.movie.jav321ja": false,
    "scraper.movie.javbus": false,
    "scraper.movie.javbusja": true,
    "scraper.movie.javbuszh": false,
    "scraper.movie.javlibrary": true,
    "scraper.movie.javlibraryja": true,
    "scraper.movie.javlibraryzh": false,
    "scraper.movie.r18": true,
    "scraper.movie.r18zh": false,
    "scraper.option.dmm.scrapeactress": true,
    "match.minimumfilesize": 0,
    "match.includedfileextension": [
        ".asf",
        ".avi",
        ".flv",
        ".m4v",
        ".mkv",
        ".mp4",
        ".mov",
        ".rmvb",
        ".wmv"
    ],
    "match.excludedfilestring": ["^.*-trailer*", "^.*-5\\."],
    "match.regex": 0,
    "match.regex.string": "([a-zA-Z|tT28]+-\\d+z{0,1}Z{0,1}e{0,1}E{0,1})(?:-pt){0,1}(\\d{1,2})?",
    "match.regex.idmatch": 1,
    "match.regex.ptmatch": 2,
    "sort.movetofolder": 1,
    "sort.renamefile": 1,
    "sort.maxtitlelength": 100,
    "sort.create.nfo": true,
    "sort.create.nfoperfile": true,
    "sort.download.actressimg": true,
    "sort.download.thumbimg": 1,
    "sort.download.posterimg": 1,
    "sort.download.screenshotimg": 0,
    "sort.download.trailervid": 0,
    "sort.format.delimiter": ", ",
    "sort.format.file": "<ID>",
    "sort.format.folder": "<ID> [<STUDIO>] - <TITLE> (<YEAR>)",
    "sort.format.posterimg": ["folder"],
    "sort.format.thumbimg": "fanart",
    "sort.format.trailervid": "<ID>-trailer",
    "sort.format.nfo": "<ID>",
    "sort.format.screenshotimg": "fanart",
    "sort.format.screenshotfolder": "extrafanart",
    "sort.format.actressimgfolder": ".actors",
    "sort.metadata.nfo.translatedescription": 0,
    "sort.metadata.nfo.translatedescription.language": "en",
    "sort.metadata.nfo.displayname": "[<ID>] <TITLE>",
    "sort.metadata.nfo.seriesastag": true,
    "sort.metadata.nfo.firstnameorder": false,
    "sort.metadata.nfo.actresslanguageja": 1,
    "sort.metadata.thumbcsv": true,
    "sort.metadata.thumbcsv.autoadd": true,
    "sort.metadata.thumbcsv.convertalias": true,
    "sort.metadata.genrecsv": true,
    "sort.metadata.genre.ignore": ["^Featured Actress", "^Hi-Def", ".*sale.*"],
    "sort.metadata.requiredfield": ["id", "coverurl", "genre", "maker", "releaseDate", "title"],
    "sort.metadata.priority.actress": ["dmmja", "r18"],
    "sort.metadata.priority.alternatetitle": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.coverurl": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.description": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.director": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.genre": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.id": ["javlibraryja", "javlibrary", "javbusja", "dmmja", "dmm", "r18"],
    "sort.metadata.priority.label": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.maker": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.releasedate": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.rating": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.runtime": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.series": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.screenshoturl": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.title": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "sort.metadata.priority.trailerurl": ["dmmja", "javlibraryja", "dmm", "r18", "javlibrary", "javbusja"],
    "emby.url": "http:\/\/localhost:8096",
    "emby.apikey": "****",
    "javlibrary.baseurl": "http:\/\/www.javlibrary.com",
    "admin.log": 1,
    "admin.log.level": "info"
}

@jvlflame
Copy link
Collaborator

Thanks, you're right about that interaction. I forgot to add the parameter to the sorted nfo output.

@ozawaslave
Copy link
Author

Did a fresh git pull on the dev branch. It's fixed.

@jvlflame jvlflame linked a pull request Sep 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants