Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DMM Trailer #90

Merged
merged 5 commits into from
Sep 21, 2020
Merged

Conversation

seeyabye
Copy link
Collaborator

This PR adds a DMM trailer for DmmJA.

@seeyabye seeyabye marked this pull request as draft September 19, 2020 03:20
@seeyabye
Copy link
Collaborator Author

I realized that there's different trailer qualities. I should check this accordingly.

@jvlflame
Copy link
Collaborator

Thanks for the PR @seeyabye!

For reference on the R18 scraper, I just have it default to the highest quality version rather than output all found qualities.
Have you tested the function on both the English/Japanese dmm sites, or only the Japanese one?

@jvlflame jvlflame added the enhancement New feature or request label Sep 19, 2020
@seeyabye
Copy link
Collaborator Author

I have revised the way of getting the trailer URL. It should now get the highest quality by default as well.

As for the tests, I've only done it on the Japanese DMM site. I'm not too sure how to test it on the English DMM site as I constantly get redirected back to the Japanese version.

@seeyabye seeyabye marked this pull request as ready for review September 19, 2020 05:45
@jvlflame jvlflame self-requested a review September 20, 2020 07:50
src/Javinizer/Private/Scraper.Dmm.ps1 Outdated Show resolved Hide resolved
@seeyabye
Copy link
Collaborator Author

I've incorporated the fix. @jvlflame do you mind checking if it works for dmm? Thanks!

@jvlflame
Copy link
Collaborator

After further testing, turns out we do need to incorporate the websession in in $trailerPageUrl.
I made a few small changes to resolve that, so we should be good to merge.

@jvlflame jvlflame merged commit 918fe8d into javinizer:master Sep 21, 2020
@seeyabye seeyabye deleted the feature/dmm-trailer branch September 25, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants