-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DMM Trailer #90
Conversation
I realized that there's different trailer qualities. I should check this accordingly. |
Thanks for the PR @seeyabye! For reference on the R18 scraper, I just have it default to the highest quality version rather than output all found qualities. |
083d590
to
0e7607f
Compare
I have revised the way of getting the trailer URL. It should now get the highest quality by default as well. As for the tests, I've only done it on the Japanese DMM site. I'm not too sure how to test it on the English DMM site as I constantly get redirected back to the Japanese version. |
I've incorporated the fix. @jvlflame do you mind checking if it works for |
After further testing, turns out we do need to incorporate the websession in in $trailerPageUrl. |
This PR adds a DMM trailer for DmmJA.