Bug: snuffleupagus requires quotes in ifs.

[majkeldzordan]

The latest version (previously there was no problem) has a strange bug. I accept the thought that this is kind of a patch, but:

1. should not be enabled by default
2. I have not found any info on how to turn it off.

Well. When I download the contents of the file (here: the test.txt file has only one character - a number, e.g. 0), the code:

$variable = file_get_contents ("test.txt");
if ($variable == "0") // works fine
if ($variable == 0) // doesn't work

I am not sure if for the above mentioned reason there is also a problem with older versions of WordPress (I do not penetrate its code so thoroughly), eg 4.9.x. After logging into wp-admin, there is a "update database" loop - it cannot be done. Disabling snuffleupagus or downgrade also solves this problem.

[jvoisin]

Do you have sp.sloppy_comparison.enable(); in your configuration file?

[majkeldzordan]

Configuration file was empty. Adding this parameter will fix the problem (I'm currently working on an older version to keep everything working)? If I understand the documentation correctly then no.

[jvoisin]

Can you try anyway?

[majkeldzordan]

I tested it. I updated snuffleupagus, added to the configuration file:
sp.sloppy_comparison.enable ();
and it still doesn't work.

[jvoisin]

I can reproduce the issue locally, there is indeed a bug in Snuffleupagus. I'm working on a fix.

[jvoisin]

Are you using PHP8?

[majkeldzordan]

I tested it on 7.4.

[jvoisin]

Should be fixed via e6219a0