Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page scrolls out of view of the calendar #110

Open
alexDrinkwater opened this issue Jul 29, 2021 · 12 comments
Open

Page scrolls out of view of the calendar #110

alexDrinkwater opened this issue Jul 29, 2021 · 12 comments

Comments

@alexDrinkwater
Copy link
Collaborator

Thanks @alexDrinkwater
One request on this (that someone else mentioned in another issue/comment thread): the Windows v10.3 script’s page refresh scrolls to the bottom of the page which, on my laptop, means I can’t see the calendar and have to take a second to scroll up when I hear the alert. Is there a way to make it refresh and set back to the portion of the page where the calendar is visible?
Thank you for all you’re doing!!

Originally posted by @JulieONeill in #105 (comment)

@alexDrinkwater
Copy link
Collaborator Author

This is the offending piece of code:

image

@stilljake
Copy link
Contributor

Is this an issue though? the script is selecting the date, so it shouldn't be necessary to scroll back up to the calendar.

@JulieONeill
Copy link

JulieONeill commented Jul 29, 2021

@stilljake It wasn’t an issue in v10.2 (as the script selected the date and you could just tick “not robot” and “next” without clicking on the date available) but that doesn’t seem to be working in v10.3 and @alexDrinkwater suggested clicking on the date before “not robot” & “next” - which means we need to see the calendar and that takes time if you need to scroll

@JulieONeill
Copy link

I’m not a coder so don’t know if the “offending piece of code” above is something that can be changed in the v10.3 script or not?

@mochi889
Copy link

mochi889 commented Jul 29, 2021

I’m not a coder so don’t know if the “offending piece of code” above is something that can be changed in the v10.3 script or not?

Me too , i dont know where is it . I spend 4 hours to find that "piece of code" and i only found it on source , not the script .

@stilljake
Copy link
Contributor

Ahh ok I didn't realise it was not selecting dates automatically anymore. Yes that piece of code can easily be changed. What it is doing is saying "find the next next button on the page and scroll to it" via the scrollIntoView method. Im not 100% sure but i think scrollIntoView scrolls the item to the top of the page. There might be something else we could scroll to instead that would work better.

@JulieONeill
Copy link

@stilljake Thanks for clarifying! What about scrolling to the Jul 1 button so the whole calendar (July-November) is in view?
(I have zero idea how to do that from a coding perspective and, if/when the code is clear, hopefully the experts here can update the script file as a new version - as I wouldn’t know how to paste in any new bit of code by myself, sorry!)

@JulieONeill
Copy link

JulieONeill commented Jul 29, 2021

PS I’m not 100% sure it’s NOT selecting dates automatically anymore (the “next” button still becomes active when the alert goes which makes it seem like the date is selected) but, given the issue raised in another thread (#105) about the v10.3 not clearly working to secure vouchers yet, @alexDrinkwater had suggested clicking on the date (before “not robot” & “next” to see is that helped)

@mochi889
Copy link

@JulieONeill where i can change that piece of code please :(

@JulieONeill
Copy link

@mochi889 As above, I unfortunately have zero idea how to do that from a coding perspective and, if/when the code is clear, I’m hoping the experts here can update the script file as a new version - as I wouldn’t know how to paste in any new bit of code by myself either, sorry!

@mochi889
Copy link

Thanks @JulieONeill

@JulieONeill
Copy link

JulieONeill commented Jul 30, 2021

This issue can be resolved by zooming out on your browser. Eg on chrome for windows- hold control + “-“ keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants