Blacken entire project

[TillerBurr]

Blacken the entire project. Solves #87.

[jwag956]

So what do I/we need to do to actually use this? This change looks like it verifies as part of pytest - but what (if any) options to actually format?
Should we place black as part of 'test_requires'?

Should we be cool and add a badge to our README: https://github.com/python/black#show-your-style?

Other than that - looks good...

[jwag956]

do we still need this?

[TillerBurr]

We can get rid of that one.

[TillerBurr]

Black shouldn't be part of tests require. The CI tests would fail for python less than 3.6. pytest-black actually skips the formatting checks if black is not available. The only thing you can modify is the line length.

I completely forgot about linting though. I'm thinking about flake8 or pylint (for things like unused imports.) I'm going to do another commit, but it gets tricky with the long key:value pairs(two factor change method password conformation in core.py)

To actually use this, the only thing that needs to be done is run black on the files. Than run linting, fix errors and ignore lines if necessary.

[TillerBurr]

Maybe some precommit hooks should be added in order to force linting and such. Don't be afraid to create other pull requests, it's fairly easy to run black and lint the files and add exceptions.

[jwag956]

Thanks - so what precisely do I (and other contributors) need to do? I.e. could you at least in the commit explain/point to links that explain how to conform? Maybe this is the first paragraph of a 'developers' RST documentation???

flakes is still part of the pytest/setup line - what else are you thinking? We can always improve - just don't want to backslide.

[jwag956]

I dont think we should add a precommit hook - that basically forces people to do development a particular way - we already have PRs that run CI - so that will catch anything we need.

We have pytest-flakes - so that is a basic linter and since your CI ran succeeded it means you managed to get things right.
As for names like 'two factor change method password conformation' that is simply painful - we should change the name - it isn't really 'change_method' anyway it for changing anything in your 2FA profile (and I am working on opt-in mode). So we could just change that to tf_confirm_password ...

[TillerBurr]

I'll work on a CONTRIBUTING.rst for this. Not much is required, except running black on the code and making sure that flake8 isn't throwing errors.

pytest-flakes really only catches logical errors, not things like unused imports. flake8 incorporates pyflakes (pytest-flakes is based off of this) and pycodestyle (formerly pep8, which is what pytest-pep8 is based on).

[jwag956]

I like what you are doing - however could we break this into separate PRs so we don’t mix simple formatting change with new setup and build and develop changes?
Let’s get black in first - then we can look into changing over to new packaging (which presumably we don't need setup.py anymore)?

Thanks

[jwag956]

bad example? python 2.7?

[TillerBurr]

That is a bad example, I'm probably going to remove that. Just an artifact from a contributing.rst (coverage.py) that I found.

[TillerBurr]

Fair enough. Removed the Contributing docs for now. I'm still looking at Poetry for building. Currently, I just use it for the virtualenv management and dependency resolution.

[jwag956]

closes: #87