Add quart compatibility. #189
Conversation
- quart_compat.py [A simple test modules with 1 function only.] - Quart compatibility fixes to get it working with it.
flask_security/cli.py
Outdated
| @@ -78,7 +103,6 @@ def users_create(identity, password, active): | |||
| @roles.command("create") | |||
| @click.argument("name") | |||
| @click.option("-d", "--description", default=None) | |||
| @click.option("-p", "--permissions") | |||
There was a problem hiding this comment.
This is a new capability in Flask-Security.. so shouldn't be removed.
There was a problem hiding this comment.
I'll fix that. Code was mainly copy pasted from an older source version.
flask_security/utils.py
Outdated
| @@ -612,7 +612,7 @@ def default_want_json(req): | |||
| if req.is_json: | |||
| return True | |||
| # TODO should this handle json sub-types? | |||
| if req.accept_mimetypes.best == "application/json": | |||
| if req.accept_mimetypes["application/json"] >= 1.0: | |||
There was a problem hiding this comment.
Not sure this is quite the same condition - I realize that quart doesn't fully support werkzeug - however if you support http spec - you probably need to support it. In any case - if you can't - lets make this another conditiponal.
There was a problem hiding this comment.
After adding this, I think your right. Problem is that quart doesnt have a .best in their function.
We could try to polyfill or make our on method though...
Probably but the only thing that would break the entire system would be quart_compat.py check. which is unlikely unless they renamed flask_patch to something else. EDIT2: The python2.7 tests has been bugging me, I dont think we have asyncio back then. With this PR, Python 2.7 should stop working though... |
|
For now - I am following Pallets lead on keeping py2.7 support. I don't know when they will drop it - hopefully soon! |
Not really. The issue is that On second thoughts doing a try and except could work... |
- py.27 tests fixed hopefully - best property attribute filling - We try and catch a attribute error for default_wants_json - PY3 Test
|
Try and catch doesnt seem to work on python 2.7 tests... We COULD try this: https://stackoverflow.com/a/57023749 (An exec a hardcoded script source) But at that point, "Is it worth it?" |
- Python 2 compatibility... hope this time it works. - Implement our own best function if it doesn't exist [Quart backwards compatibility.]
There was a problem hiding this comment.
Sorry for all the hassle. Here is an experiment I did which I think is a lot cleaner:
Add a new file async_compat.py:
from flask import current_app
from werkzeug.local import LocalProxy
_security = LocalProxy(lambda: current_app.extensions["security"])
_datastore = LocalProxy(lambda: _security.datastore)
async def _commit(response=None):
_datastore.commit()
return response
In views.py:
if PY3:
import async_compat # noqa: F401
else:
def _commit(response=None):
_datastore.commit()
return response
And finally - in pytest.ini add:
async_compat.py ALL
|
I cloned your PR, fixed coverage issues and merged... Thanks! |
|
Thanks again for all your work. :) |
This PR adds:
quart_compat.py[A simple test module with 1 function only.]async_compat.py[Conditional import]If this PR gets accepted, this would fix issues with quart with flask-security.
This does not affect any flask functionality as far as I'm aware.
If I need to fix/change/lint anything please let me know.