Add argon2 as allowable password hash. #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple really - and add a comment in the docs that you probably have to install an additional package to use it. Argon2 implementation doesn't honor the deprecated passlib model of passing in options at hash time. Added a new config variable SECURITY_PASSWORD_HASH_PASSLIB_OPTIONS that is used a CryptContext creation time that is the new passlib model for how to set hash options. Kept the SECURITY_PASSWORD_HASH_OPTIONS for backwards compat. Argon2 doesn't need double hash - so add it to 'SINGLE' hash list. Convert example to use argon2. closes: #205 closes: #133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple really - and add a comment in the docs that you probably have to install an additional package to use it.
Argon2 implementation doesn't honor the deprecated passlib model of passing in options at hash time.
Added a new config variable SECURITY_PASSWORD_HASH_PASSLIB_OPTIONS that is used a CryptContext creation time
that is the new passlib model for how to set hash options.
Kept the SECURITY_PASSWORD_HASH_OPTIONS for backwards compat.
Argon2 doesn't need double hash - so add it to 'SINGLE' hash list.
Convert example to use argon2.
closes: #205
closes: #133