Opr839 #80
Merged
Opr839 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add copyright Fix .gitignore so new file wouldn't be mistaken Use config_value() utility function to fetch config values Added new config values to core.py.
|
Looks good 👍 Thank you @jwag956 for help and improvements. |
|
@jwag956 it is cool you merged ! |
|
3.2.0rc1 is up with your changes: |
|
@jwag956 -- thanks for merging this in, I think it'll be useful for me. Curious, does this cover the case where a user changes their password? I think that would invalidate the token right? Or would the old token still "work" (in cache) until a new one is generated (via TTL timeout), thus this is a non-issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.