feature - Support Json/Single-Page-Applications #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset Password, passwordless login, and confirmation did not support SPA/json since those three had confirmation links that only returned redirects or forms. SPAs need to get control of all redirects and have the appropriate context. Three new 'views' are available: RESET_VIEW, RESET_ERROR_VIEW, and LOGIN_ERROR_VIEW to enable easy routing within the UI. This change introduces a new config variable - SECURITY_REDIRECT_BEHAVIOR which will change those redirects to SPA-friendly redirects. A new overridable UserMixin method - get_redirect_qparams allows for customizing precisely what query arguments are sent via the redirect. By default of course the existing form-based redirects are done. A new configuration variable - REDIRECT_HOST can be used during development to force redirects to a different netloc useful when the UI is running separately (e.g. via npm). Continued to improve the openapi.yaml file to document these changes Improved unit tests by: 1) verifying 'flashes' - for json/SPA - we don't want any. 2) improve performance by not using bcrypt for login tokens during testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset Password, passwordless login, and confirmation did not support SPA/json since
those three had confirmation links that only returned redirects or forms. SPAs need to get control
of all redirects and have the appropriate context. Three new 'views' are available:
RESET_VIEW, RESET_ERROR_VIEW, and LOGIN_ERROR_VIEW to enable easy routing within the UI.
This change introduces a new config variable - SECURITY_REDIRECT_BEHAVIOR which will change those redirects to SPA-friendly
redirects. A new overridable UserMixin method - get_redirect_qparams allows for customizing precisely what
query arguments are sent via the redirect.
By default of course the existing form-based redirects are done.
A new configuration variable - REDIRECT_HOST can be used during development to force redirects to a different netloc
useful when the UI is running separately (e.g. via npm).
Continued to improve the openapi.yaml file to document these changes
Improved unit tests by: