fix: Improve 2FA views. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as documented in Issue #90: - add initialization and tests for the 3 2FA form context processors. - for 2fa login - improve JSON response so can decide what next state is. - add 2FA URL configurations and documentation. - allow for both 2FA and normal logins - see below. All logins now go through /login - however if SECURITY_TWO_FACTOR is true - all login's require 2FA. Next step is to make this per-user. No change in behavior. Backwards compat: Other 2FA views have changed default endpoint URLS: /two_factor_setup_function -> /tf-setup /two_factor_token_validation -> tf-validate /change/two_factor_password_confirmation -> /tf-confirm /two_factor_rescue_function -> /tf-rescue closes: #90
TillerBurr
approved these changes
Jun 5, 2019
|
Thanks for your quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as documented in Issue #90:
All logins now go through /login - however if SECURITY_TWO_FACTOR is true - all login's
require 2FA. Next step is to make this per-user. No change in behavior.
Backwards compat:
Other 2FA views have changed default endpoint URLS:
/two_factor_setup_function -> /tf-setup
/two_factor_token_validation -> tf-validate
/change/two_factor_password_confirmation -> /tf-confirm
/two_factor_rescue_function -> /tf-rescue
closes: #90