Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer bin #1

Closed
wiese opened this issue Oct 20, 2016 · 3 comments
Closed

composer bin #1

wiese opened this issue Oct 20, 2016 · 3 comments

Comments

@wiese
Copy link
Contributor

wiese commented Oct 20, 2016

Hi Jonathan,

promising new project - congrats.
One thing that caught my eye is the path to the "binary". Not sure if you omitted it on purpose, but why not make it globally accessible via composer; especially when used in another project (which must be the final goal)?
https://getcomposer.org/doc/articles/vendor-binaries.md

Cheers

@jwage
Copy link
Owner

jwage commented Oct 20, 2016

It isn't clear to me yet how that could work since the binary needs to be customized and setup for each project currently.

@jwage
Copy link
Owner

jwage commented Oct 21, 2016

This should work now. You can take a look at jwage/phpchunkit-demo

@jwage jwage closed this as completed Oct 21, 2016
@wiese
Copy link
Contributor Author

wiese commented Oct 21, 2016

Awesome. Just wanted to clarify - but you guys are quick! I agree keeping the bin file the immutable entrypoint and configuring via another file is probably the cleanest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants