Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorded tracks are combined into one file #170

Open
rklrkl opened this issue Jan 26, 2020 · 6 comments
Open

Recorded tracks are combined into one file #170

rklrkl opened this issue Jan 26, 2020 · 6 comments
Labels
bug 🐞 help wanted 👋 recorder 🎵 Related to recording or encoding to WAV, MP3 with ID3 tags

Comments

@rklrkl
Copy link

rklrkl commented Jan 26, 2020

What problem will this new feature resolves ?
Some albums/playlists have very short gaps between tracks (I have Crossfading and Automix disabled in the Spotify client to try to get a silence gap) and Spytify will often miss the gap and continue appending the next track onto the end of the current one leading to two (or more!) tracks combined into one mp3.

What feature or enhancement would you like to see added ?
It would like an option to specify the inter-track gap interval in 0.1 sec increments (min: 0.1 sec, maybe default 1.0 sec?) so that I can adjust this value for albums/playlists that have shorter than normal inter-track gaps. As it stands, I have to create multiple 1-track playlists for adjacent tracks (and stop/start recording for each) with this problem, which is very inconvenient.


Want to back this issue? Post a bounty on it! We accept bounties via IssueHunt.

@jwallet
Copy link
Owner

jwallet commented Jan 26, 2020

i don't think this should be in any way a setting, but maybe a code fix. i will see how i could improve this. sometimes, it's just spotify that does not update its status at the proper time, resulting in faulty results with spytify. looks like they do it on purpose to mess with recorders.

I will like also to know which songs you were recording or which song got recorded in the same file, so i can try it on my end

having two songs in the same file is a spytify bug if spotify actually told spytify that the song changed. so that's why i would like to try to record the same songs that you did.

also #137 will solve your issue if implemented since it would be more accurate

edit: related to #100

@jwallet jwallet changed the title Configurable inter-track gap interval Recorded tracks are combined into one file Jan 26, 2020
@jwallet
Copy link
Owner

jwallet commented Mar 13, 2020

might be related to / fixed by #205 as well

@jmevel
Copy link

jmevel commented Mar 24, 2020

I too am facing this issue.
@jwallet you can reproduce this bug with this album: https://open.spotify.com/album/3dPtahH1qEgcBi1Q7YwNSM?si=f17dMYWeTJmvenAEtvRpDg

@jwallet jwallet added the recorder 🎵 Related to recording or encoding to WAV, MP3 with ID3 tags label May 6, 2020
@jwallet
Copy link
Owner

jwallet commented Jan 10, 2021

I too am facing this issue.
@jwallet you can reproduce this bug with this album: https://open.spotify.com/album/3dPtahH1qEgcBi1Q7YwNSM?si=f17dMYWeTJmvenAEtvRpDg

So after some tests, it looks like Spotify does not delivery the max quality of 160kbps for this album, it gets delivered (on my side) at 56kbps, mainstreams tracks on spotify are always at 160kbps (100%), so what could happen when encoding at lower bit rates is the length of the track increased without affecting the music, when playing the track it will stop playing the full track half way.

a track with an original length of 3 minutes, can gets 13 minutes length at lower bit rates, when you play it, it stops at 3 minutes / 13 minutes.

selected bit rate in spytify will affect encoding this way. Normally if you have Spotify Free you should select 160kbps , Spotify Premium 320kpbs.

so on my side, I get the full track but with twice the length.

@alpharou
Copy link

Could it be possible to fetch the track metadata and then stop the recording exactly at the end? (Assuming the recording started exactly at 0:00).

Or hook to the windows media keys and hit rewind and play, then record at 0:00.

Then it would be possible to record crossfaded tracks.

@jwallet
Copy link
Owner

jwallet commented Jan 24, 2021

@alpharou this is something that won't work with lastfm api, and even when using spotify api it won't be perfect.

upcoming spytify version will use spotiy api to generate track change events (currently the api is only used for fetching metadata), and even when using the api to detect when the track changes it can still have some delay. the api also differs from 1s to the streamable length of a track resulting in worst results (you don't want the next track to be recorded at the end of the current track for all your recordings).

the issue above is more likely to be caused by the pc going idle after the user left (more frequent on laptop than pc), you can install caffeine to prevent your pc/laptop setting app process to sleep, (caffeine simulates key press every minute or so, which makes the pc thinks the user is still using the pc)

upcoming version will generate mp3 files will more accurate bit rate values, the quality should increased a bit and make stop #102 some bad encoding effects to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 help wanted 👋 recorder 🎵 Related to recording or encoding to WAV, MP3 with ID3 tags
Projects
None yet
Development

No branches or pull requests

4 participants