New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track recorded on the same file as the precedent track #435
Comments
This seems to be happening when I move or add anything to a playlist above the current song (i.e. a song before the current playing song) |
It happens for me but i didn't move anything, just launched my playlist and wait. |
@Coca162 I've just tried to record a playlist without changing anything, but this issue still occurred. In my scenario the logs looked like this (spacing mine for clarity):
|
I've had a look into the code and I've narrowed down the cause of this. What appears to be happening is that when a new track is queued up, the previous track is written to disk. This all happens at the same in an asynchronous manner. A process goes off to discover the title for the new track from an API, but when it is set, it uses the title from the previous track. The track's Title property is used to form the file names, so this is where the problem begins. I haven't spotted a solution, but at least I'm closer to the cause :-) |
Are you guys using Spotify desktop app from spotify website (.exe file downloaded) or from the Windows Store? I did not have an issue like that and I'm using the app from Windows Store. |
Ah! I'm using a version built from the github code. I wanted to edit the code to prefix file names with a track number |
After using Spytify for a bit more I do indeed have this issue even when not moving anything around. Also @jwallet I am using the Spotify desktop app from the exe. |
I have also started encountering the same problem. I've been using release 1.10.1 for a while, and this only started happening recently. I've also noticed that this doesn't happen when using the LastFM API instead of the Spotify API |
It could well be something that has changed at Spotify's side. If the API takes a little longer to respond than previously it could have exposed a race condition in the existing code. |
Anyone tried to record using Spotify from the Windows Store, I'm currently recording and I still have no problem, 23 tracks recorded so far, none missing. So I'm wondering if I using the .exe file from their website produces that bug. Of course while recording it's better to keep the windows session active and not lock your PC for example, Spytify will still record, but if I remember correctly Spotify won't provide track info if the window is not rendered at all (like the screen went to sleep). I'm thinking to add a caffeine feature to the app if that is the issue. If someone will like to help out, you can try one of the following "solution" to know if one of these fixes the bug;
|
did someone here tried the latest release? I would like to know if it resolved the issue |
For info: I've update my fork of the code, re-built, and run a test today. I'm not seeing the problem anymore :-)
|
I've updated to the latest release (love the auto-update feature btw!) and I am no longer encountering this problem 🥳 |
i'm closing this issue then, thanks all for your feeback it's appreciated |
Hi !
First really nice project.
My first recording sessions worked well.
But today I try to do another and as you can see Spytify record the first track well.
Then for the second track it will overwrite the audio of the first one.
Version: 1.10.1
In final for 2 tracks recorded I end with 1 file with the ID3 data of the first and the audio of the second.
Edit:
So I have downloaded again Spytify and the bug is not happening for now.
Edit 2:
It happened again :/
The text was updated successfully, but these errors were encountered: