Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track numbers set as 1 greater than should be #453

Open
techdog0 opened this issue Dec 2, 2022 · 1 comment
Open

Track numbers set as 1 greater than should be #453

techdog0 opened this issue Dec 2, 2022 · 1 comment
Labels
bug 🐞 cannot reproduce ❌ recorder 🎵 Related to recording or encoding to WAV, MP3 with ID3 tags user interface 👀

Comments

@techdog0
Copy link

techdog0 commented Dec 2, 2022

What is the bug ?

A clear and concise description of what the bug is.
Steps to reproduce the behavior or describe the expected behavior:

Configuration is set to write counter to track number in MP3. Track number that gets written is 1 greater than actual track number AND track number/counter used in file name.

It seems like the counter is being incremented to write the file name before the track number is written to the file attributes.

If there is nothing following on spotify, that is, if it is the last track to record, it works fine.

Track used

Spotify track/playlist used : https://open.spotify.com/search

Screenshots

If applicable, add screenshots to help explain your problem.

@jwallet
Copy link
Owner

jwallet commented Jan 6, 2023

I try both settings

  • Add the counter number in front of the file names
  • Replace track number tag by the counter value

They seem to work correctly, the counter will be apply on track being recorded, so when the recording ends, a new track is being recorded and the one that is encoded to mp3 will have the previous counter value since the new value will be apply to the track you are hearing which is not encoded yet.

If the counter value is 9 and you skip the track it will look something like that

[11:07:01] Recording: Red Hot Chili Peppers - Under the Bridge #counter value is 9
[11:07:11] Recorded: ..\Red Hot Chili Peppers - Under the Bridge.mp3 in 00:09 #counter value 9 applied
[11:07:19] Recording: Foo Fighters - Learn to Fly #counter value is 10

If you stop the session the counter value increments to 11 since it will encode the last track to mp3 and will set the next value for the next session.

image

image

@jwallet jwallet added cannot reproduce ❌ recorder 🎵 Related to recording or encoding to WAV, MP3 with ID3 tags user interface 👀 labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 cannot reproduce ❌ recorder 🎵 Related to recording or encoding to WAV, MP3 with ID3 tags user interface 👀
Projects
None yet
Development

No branches or pull requests

2 participants