Read alpha as the fillOpacity property
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
👍 |
jwass
added a commit
that referenced
this pull request
Dec 14, 2015
Read alpha as the `fillOpacity` property
|
@ocefpaf Nice. Thanks. Makes sense - setting only the edge opacity was definitely a bug. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is the best way to implement it because matplotlib's
alphais defined only once, while in leaflet we haveopacityfor the stroke opacity andfillOpacityfor the patch opacity.However, I believe we need to override leaflet's default
fillOpacity, which is only 0.2, to fix visualizations like this one:http://nbviewer.ipython.org/github/rsignell-usgs/mwra-wq/blob/master/notebooks/wq_test.ipynb