Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden POI - Point Marker missing - TYPO3 Backend #221

Closed
rasgor opened this issue Jun 23, 2021 · 2 comments
Closed

Hidden POI - Point Marker missing - TYPO3 Backend #221

rasgor opened this issue Jun 23, 2021 · 2 comments

Comments

@rasgor
Copy link

rasgor commented Jun 23, 2021

Maybe it's a matter of opinion but isn't it usefull to see the marker position on the map even if the POI is hidden?

The marker disapears from the map if the POI is set to hidden.

EXT:maps2/Classes/Form/Element/OpenStreetMapElement.php

Line 165:

$poiCollection = $this->poiCollectionRepository->findByUid($uid);

This seems to be the problem. Same applies for the GoogleElement

Settings:
TYPO3 10.4.17
maps2 9.3.7
map type osm

Best regards
Robert

@froemken
Copy link
Contributor

froemken commented Oct 6, 2021

You are right. Using Extbase in backend form is a bad idea ;-)
While my work upgrading maps2 for TYPO3 11 I have reduced extbase calls a lot. As you see in branch typo3_11_compatibility the PoiCollectionRepository has gone completely:

https://github.com/jweiland-net/maps2/blob/typo3_11_compatibility/Classes/Form/Element/OpenStreetMapElement.php#L132

I mark this problem as solved. It will be integrated with upcoming maps2 version 10.0.0.

Thank you for your report.

Stefan

@froemken froemken closed this as completed Oct 6, 2021
@rasgor
Copy link
Author

rasgor commented Oct 7, 2021

Tank you for your answer and improvements of this extension. Keep up the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants