Macroexpand quoted eval-after-load block early #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main `use-package' macro incorrectly planted code containing a call to the `with-elapsed-timer' macro in a quoted block to be run by `eval-after-load'. If package use-package was not loaded at runtime, the block would error saying correctly that `with-elapsed-timer' is undefined. This mod correctly macroexpands the block at code generation time.
jwiegley
added a commit
that referenced
this pull request
Jan 24, 2013
Macroexpand quoted eval-after-load block early
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Nov 24, 2022
Macroexpand quoted eval-after-load block early GitHub-reference: jwiegley/use-package#13
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Nov 29, 2022
Macroexpand quoted eval-after-load block early GitHub-reference: jwiegley/use-package#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
use-package' macro incorrectly planted code containing a call to thewith-elapsed-timer' macro in a quoted block to be run byeval-after-load'. If package use-package was not loaded at runtime, the block would error saying correctly thatwith-elapsed-timer' is undefined. This mod correctly macroexpands the block at code generation time.