Support keymap symbol in bind-key. Fix #845 #846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, there are packages such as prettier that expose commands that one would like to bind to multiple modes in their mode hooks. In which case the mode map will likely be dynamically constructed from the mode symbol, and one would like to bind keys like the following:
The problem is,
bind-key
currently does not supportKEYMAP
supplied as a symbol, and if it is supplied as a(symbol-value (derived-mode-map-name mode))
, there's no way to reverse lookup the name of the variable from the symbol value later on when constructing the buffer fordescribe-personal-bindings
, hence #845 .This PR proposes a fix to this problem by supporting KEYMAP as symbols, while preserving backward compatibility.