Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected 204 errors? #8

Open
jwietelmann opened this issue Jan 19, 2021 · 0 comments
Open

Handle unexpected 204 errors? #8

jwietelmann opened this issue Jan 19, 2021 · 0 comments

Comments

@jwietelmann
Copy link
Owner

When using the address validation endpoint, I momentarily forgot to have my test POST any params. Instead of receiving any kind of error, I got a 204 No Content, which implies success. (This is something I'd consider a bug on TaxJar's end, but it would demand an API version bump if fixed, IMO.)

Anyway, my code's returning {:ok, _} in this case. But it's not okay! What actually happened was the API server more or less rejected the request for lack of appropriate params.

(Cursory testing suggests the problem is probably limited to /addresses/validate.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant