Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifiy titleFontSize #46

Closed
DavidLibeau opened this issue May 30, 2020 · 1 comment
Closed

Unifiy titleFontSize #46

DavidLibeau opened this issue May 30, 2020 · 1 comment

Comments

@DavidLibeau
Copy link

Some charts have titleFontSize with a default value set to '1rem' and others set to '0.95rem'.
For consistency, I think that all charts should have the same default value.

@jwilber
Copy link
Owner

jwilber commented Jun 25, 2020

It's set as follows on charts:

style('font-size', (this.titleFontSize === undefined) ?
        `${Math.min(40, Math.min(this.width, this.height) / 5)}px` :
        this.titleFontSize)

Not sure where you're getting the 1rem from?

@jwilber jwilber closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants