Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive: a and -> an and /and/ #10

Open
pabs3 opened this issue Sep 26, 2023 · 2 comments
Open

false positive: a and -> an and /and/ #10

pabs3 opened this issue Sep 26, 2023 · 2 comments

Comments

@pabs3
Copy link

pabs3 commented Sep 26, 2023

There is a false positive when a comes before and, which can happen in lists/pairs:

$ echo 'Please download a and b to continue.' | anorack -
<stdin>:1: a and -> an and /and/

Converting a and b to an and b breaks the a, which isn't used as an indefinite article here so should not be changed.

@jwilk
Copy link
Owner

jwilk commented Oct 2, 2023

It's more complicated than it seems. Sometimes "a and" is a true positive, e.g.:

Create a and node for combining lessThanRow and lessThanCol

(example from nvidia-cudnn-frontend)

@pabs3
Copy link
Author

pabs3 commented Oct 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants