-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Beam, Underline cursors #608
Conversation
Notable about this implementation is it takes a different approach for managing cursor cells that previously. The terminal Grid is now borrowed *immutably*. Instead of mutating Cells in the Grid, a list is managed within the RenderableCellsIter. The cell at the cursor location is skipped over, and instead cells are popped off a list of cursor cells. It would be good in the future to share some more code between the different cursor style implementations for populating the cursor cells list. Supercedes #349.
Works nicely 🙂 @jwilm out of curiosity, why did you choose symbols "▎" and "▁" for the cursor shapes? I don't know if this is right or wrong choice, I simply noticed that my |
@maximbaz I tried with Maybe the beam and underscore characters should be configurable? Maybe there's some other codepoint I've overlooked that would be good for the underscore? The symbols chosen here are from the block elements block. |
How do you use this? Did you forget to update the config files? Edit: it works in neovim with |
@NickeZ the build from master branch works for me in Neovim(0.2.1; with default EDIT: added nvim version |
@dm1try strange, it doesn't for me.. tried to remove the line from my init.vim and I'm back to the old block symbol in insert mode.. |
The sizes are wrong for my font. The |
@jwilm this. is. awesome. |
@jwilm I think you are right, the However, have a look at how alacritty behaves when I set Isn't that weird, how I double the suggestion from @net, perhaps instead of relying on how different systems choose to select font to render |
@jwilm how to setup it for regular vim (not neovim)? |
@aliev |
For example: let &t_SI = "\<Esc>[6 q"
let &t_SR = "\<Esc>[4 q"
let &t_EI = "\<Esc>[0 q" |
@Shougo wow! many thanks!!! |
I think it should be documented in Vim documentation... |
I don't know if I'm doing something wrong, but I'm using Alactritty 492d1bd (August 11) combined with nvim 0.2.1 and I don't see the cursor shape changing. I'm pretty sure it's not a neovim thing, as when using iTerm (or Terminal.app) I get different cursor shapes. |
I'm also having this issue. I'm using |
I had trouble with this using vim8, Alacritty and Tmux. Fixed by removing all related settings in tmux/vim/alacritty and just installing this plugin: https://github.com/jszakmeister/vim-togglecursor |
Notable about this implementation is it takes a different approach for
managing cursor cells that previously. The terminal Grid is now
borrowed immutably. Instead of mutating Cells in the Grid, a list is
managed within the RenderableCellsIter. The cell at the cursor location
is skipped over, and instead cells are popped off a list of cursor
cells.
It would be good in the future to share some more code between the
different cursor style implementations for populating the cursor cells
list.
Supercedes #349.
Resolves #171.