-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2048 is simple, writing a test for your implementation could make your package more robust #4
Comments
Hey, if you would like to contribute tests & fix the typos, a PR would be welcome! If possible, please write the tests to be able to be executed with just
in the project root directory. Once we have them running I can add CI checks using github actions. |
Will do |
I have got to admit your implementation of the 2048 is quite complex but i have gotten the pytest command line to work i will push that to you for your review. |
Which error are you getting on windows? |
I am sure it is a bug for |
I notice the intention. but i think i can write tests for your code.
Also, it might help in figuring out the /attempt #1 bug
i also discovered a few spelling errors i would like to fix.
I hope it is okay to move ahead with it.
The text was updated successfully, but these errors were encountered: