Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2048 is simple, writing a test for your implementation could make your package more robust #4

Open
ProsperoKay opened this issue Jan 17, 2024 · 7 comments

Comments

@ProsperoKay
Copy link
Contributor

ProsperoKay commented Jan 17, 2024

I notice the intention. but i think i can write tests for your code.

Screenshot 2024-01-17 173600

Also, it might help in figuring out the /attempt #1 bug

i also discovered a few spelling errors i would like to fix.
Screenshot 2024-01-17 172930
Screenshot 2024-01-17 172524

Screenshot 2024-01-17 172457

I hope it is okay to move ahead with it.

@jwlodek
Copy link
Owner

jwlodek commented Jan 17, 2024

Hey, if you would like to contribute tests & fix the typos, a PR would be welcome! If possible, please write the tests to be able to be executed with just

pytest

in the project root directory. Once we have them running I can add CI checks using github actions.

@ProsperoKay
Copy link
Contributor Author

Hey, if you would like to contribute tests & fix the typos, a PR would be welcome! If possible, please write the tests to be able to be executed with just

pytest

in the project root directory. Once we have them running I can add CI checks using github actions.

Will do

@ProsperoKay
Copy link
Contributor Author

I have got to admit your implementation of the 2048 is quite complex but i have gotten the pytest command line to work i will push that to you for your review.
After which i will work on the individual test cases

@ProsperoKay
Copy link
Contributor Author

for #1, I am unable to run py_cui on windows for some reason. When the bug gets fixed, I'll attempt #1.

@jwlodek
Copy link
Owner

jwlodek commented Feb 2, 2024

Which error are you getting on windows?

@ProsperoKay
Copy link
Contributor Author

ProsperoKay commented Feb 2, 2024

My issue is py_cui is not running in my terminal cmd. I tried the hello_py_cui example it just doesn't display as expected

image

I run the example in the terminal
python experiments/cui.py

but it yields no display as it should in the terminal

image

@ProsperoKay
Copy link
Contributor Author

I am sure it is a bug for py_cui i will create an issue for that. That is if it hasn't been reported already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants