Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to enforce linting #6

Closed
jwngr opened this issue Feb 26, 2018 · 2 comments
Closed

Add CI to enforce linting #6

jwngr opened this issue Feb 26, 2018 · 2 comments

Comments

@jwngr
Copy link
Owner

jwngr commented Feb 26, 2018

No description provided.

@mohawk2
Copy link

mohawk2 commented Apr 6, 2021

You sort of have that now; the CI is trying to deploy, but failing the build (eg https://semaphoreci.com/jwngr/sdow/branches/master/builds/123):

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

src/components/ErrorMessage.js
  Line 37:1:  Assign arrow function to a variable before exporting as module default  import/no-anonymous-default-export
[etc]

@jwngr
Copy link
Owner Author

jwngr commented Jun 19, 2024

Added in #138 and #146. Set up through a GitHub action: https://github.com/jwngr/sdow/blob/master/.github/workflows/frontend-ci.yml.

@jwngr jwngr closed this as completed Jun 19, 2024
@jwngr jwngr reopened this Jun 19, 2024
@jwngr jwngr closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants