Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Make Matplotlib optional #161

Closed
firai opened this issue Jul 1, 2023 · 2 comments
Closed

FR: Make Matplotlib optional #161

firai opened this issue Jul 1, 2023 · 2 comments

Comments

@firai
Copy link

firai commented Jul 1, 2023

Is your feature request related to a problem? Please describe.
Matplotlib, which itself carries a long list of dependencies, is currently set as a hard dependency. However, Matplotlib isn't central to the functionality of PyNite, and I often use plotly for visualization these days (or sometimes no visualization depending what I'm doing).

Describe the solution you'd like
Change Matplotlib to an optional dependency.

Describe alternatives you've considered
Create a dummy setup.py for Matplotlib each time I install PyNite, but that's very hacky and may have unintended consequences.

@JWock82
Copy link
Owner

JWock82 commented Jul 1, 2023

You bring up a good point. I'll consider this on the next revision. I'm almost always using plots to verify that the analysis was correct. I can quickly detect errors visually in my model by looking at the member diagrams. I figured most users would want to do that too.

I have no issue with making it optional. My only concern is that some inexperienced python users may not realize they need to install matplotlib to get some of the examples to work. I suppose they are already dealing with that issue with VTK and scipy which are already optional.

@JWock82
Copy link
Owner

JWock82 commented Jul 7, 2023

Completed.

@JWock82 JWock82 closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants