Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: VisNode does not render as a cone if pin-supported #85

Closed
tamalone1 opened this issue Jan 13, 2021 · 2 comments
Closed

Bug: VisNode does not render as a cone if pin-supported #85

tamalone1 opened this issue Jan 13, 2021 · 2 comments
Labels

Comments

@tamalone1
Copy link
Contributor

The elif expression on Visualization.py line 828 is identical to the preceding if expression, meaning that it never runs. This elif branch is intended to identify a pin-supported Node and render it as a cone instead of a sphere. As written, any pin-supported Node is rendered as a sphere as normal, through the else clause.

The elif expression should be changed to correspond to a pin-support (e.g. SupportMX = False, ..., etc), or removed if the cone rendering isn't desired.

elif node.SupportDX == True and node.SupportDY == True and node.SupportDZ == True \

@JWock82
Copy link
Owner

JWock82 commented Jan 13, 2021

I reorganized that code recently to simplify it. I likely created this bug when I did that. I'll fix it when I get a moment.

@JWock82 JWock82 added the bug label Jan 13, 2021
@JWock82
Copy link
Owner

JWock82 commented Jan 20, 2021

This should be fixed now. Thanks for reporting it.

@JWock82 JWock82 closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants