Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_osmajor checks should be removed #10

Open
stsp opened this issue Aug 30, 2023 · 2 comments
Open

_osmajor checks should be removed #10

stsp opened this issue Aug 30, 2023 · 2 comments

Comments

@stsp
Copy link

stsp commented Aug 30, 2023

There are a couple of cases, most
notably in sys/vfs/statfs.c, where
the libc checks if( 7 <= _osmajor && _osmajor < 10 )
and uses an extended functionality,
falling back to the basic functionality
otherwise.
The extended functionality block is
however properly implemented: it
falls back to the basic functionality
anyway, if the extended functions
failed.
There are many DOS clones around,
for which this check fails. Since the
code have the proper fallbacks anyway,
the _osmajor checks should be removed.

@jwt27
Copy link
Owner

jwt27 commented Sep 1, 2023

Hm, not sure. There may be some obscure DOS versions/flavors that do something unexpected, instead of fail normally. I would assume those checks are there for a reason.

@stsp
Copy link
Author

stsp commented Sep 1, 2023

Maybe but so far they require me to
overwrite _osmajor.
Note that obscure doses must be checked
separately for a particular broken
functionality. Removing all doses from
the bicture by the reason that some of
them may be obscure, is not a solution.
And besides, there can be tsrs that add
the missing functionality to older doses
(like doslfn).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants