Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jjwt-gson cannot use the require series methods of io.jsonwebtoken.JwtParserBuilder normally #762

Open
linghengqian opened this issue Dec 2, 2022 · 3 comments
Milestone

Comments

@linghengqian
Copy link

linghengqian commented Dec 2, 2022

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

git clone git@github.com:linghengqian/jjwt-gson-ex-test.git
sdk use java 22.3.r17-grl
./gradlew clean test
  • jjwt-jackson and jjwt-orgjson do not have this problem.

Expected behavior
A clear and concise description of what you expected to happen.

  • jjwt-gson can use the require series methods of io.jsonwebtoken.JwtParserBuilder normally.

Screenshots
If applicable, add screenshots to help explain your problem.

  • image
@lhazlewood
Copy link
Contributor

Thank you for reporting this, we'll take a look after the JWE release!

@lhazlewood lhazlewood added this to the 0.12.0 milestone Aug 11, 2023
@lhazlewood
Copy link
Contributor

lhazlewood commented Aug 11, 2023

@linghengqian do you think this would be resolved via #771 ? That would be my guess. GSON number deserialization is terrible.

@linghengqian
Copy link
Author

@linghengqian do you think this would be resolved via #771 ? That would be my guess. GSON number deserialization is terrible.

  • @lhazlewood Adopting provide an enum that indicates the 'level' of precision desired scenario may not be something that should be on the 0.12.0 milestone. This kind of proposal looks like something that a major version milestone like 1.0.0 should have.

  • Personally, I think we should use a custom ToNumberStrategy directly inside jjwt .

@lhazlewood lhazlewood modified the milestones: 0.12.0, 1.0 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants