Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIO-311 Added codeclimate badge #328

Merged
merged 1 commit into from
Feb 17, 2019
Merged

CIO-311 Added codeclimate badge #328

merged 1 commit into from
Feb 17, 2019

Conversation

celesterobinson
Copy link
Contributor

@celesterobinson celesterobinson commented Feb 16, 2019

Fixes #311
Added the CodeClimate badge as provided in the issue description to the README.md

Description

Added new badge to the README.md

Motivation and Context

Using codeCoverage to keep track of this projects code maintainability, lets add the badge to our Readme.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ x] I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@joshuabot
Copy link

joshuabot commented Feb 16, 2019

Fails
🚫

❔ This pull request should begin with the issue number.
Please include "Fixes #<ISSUE_NUMBER>" at the beginning of the description.
See Contributing Guidelines

Generated by 🚫 dangerJS

Repository owner deleted a comment from codeclimate bot Feb 16, 2019
@jwu910 jwu910 self-assigned this Feb 16, 2019
@jwu910
Copy link
Owner

jwu910 commented Feb 16, 2019

Good morning @celesterobinson, thanks for the PR! If you could just delete the first line in your description, we can get the CI to pass.

I’ll review once I get a chance, thanks again!

@celesterobinson
Copy link
Contributor Author

Sorry about that. Done!

@jwu910
Copy link
Owner

jwu910 commented Feb 16, 2019

Just started reviewing :)

:octocat: Sent from GH.

@jwu910 jwu910 merged commit ddbac61 into jwu910:development Feb 17, 2019
@celesterobinson celesterobinson deleted the CIO-311-add-codeclimate-badge branch February 17, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants