Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks in iOS calls on JXcore addNativeBlock should be the last argument #46

Open
yaronyg opened this issue Jul 16, 2015 · 2 comments
Open

Blocks in iOS calls on JXcore addNativeBlock should be the last argument #46

yaronyg opened this issue Jul 16, 2015 · 2 comments

Comments

@yaronyg
Copy link
Member

yaronyg commented Jul 16, 2015

Right now the delegates/blocks in JXCore iOS code are the first argument but Apple's style guidelines always say that blocks should be the last argument. This actually makes sense as it makes the methods easier to read.
@obastemur
Copy link
Member

@yaronyg exactly which one ?

@yaronyg
Copy link
Member Author

yaronyg commented Jul 17, 2015

Sorry. Bad bug description. I'm referring to JXcore:addNativeBlock:withname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaronyg @obastemur