Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot read property 'index' of null" in mdx-deck 1.6.7 "Notes" on build #138

Closed
trevordmiller opened this issue Aug 25, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@trevordmiller
Copy link

When using Notes like

import { Notes } from 'mdx-deck'

<Notes>
  Only visible in presenter mode
</Notes>

When I run mdx-deck build I get TypeError: Cannot read property 'index' of null originating from node_modules/mdx-deck/dist/Notes.js:44:24:

image

in mdx-deck 1.6.7

@trevordmiller
Copy link
Author

This works though:

```notes
These notes are only visible in presenter mode
```

@jxnblk jxnblk added the bug Something isn't working label Aug 26, 2018
@pomber
Copy link
Contributor

pomber commented Aug 27, 2018

There's a similar problem with Appear since v1.6.6:

[err] TypeError: Cannot read property 'step' of null
    at Appear.render (node_modules/mdx-deck/dist/Appear.js:81:30)
    ...

BTW both Notes and Appear work when using the --no-html flag.

@jxnblk
Copy link
Owner

jxnblk commented Aug 27, 2018

Thanks! I'm able to reproduce, I imagine it has something to do with webpack-node-externals not being set up correctly, but I'm looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants