-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video component #4
Comments
What should these component specifically do? Wouldn't using a provided embed code suffice? |
I think we'll want a scalable/resizable version, something like this but for fullscreen: https://github.com/jxnblk/rebass/blob/master/src/Embed.js |
A more video-centric extension of this could also have an autoplay attribute, hook into the SlideDeck context and start playing when the slide comes into view – and pause when the slide leaves the view |
This will be awesome. I really like the included fullscreen |
@jxnblk The link to rebass no longer works :( |
Updated Rebass link: https://rebass-v2.now.sh/components/Embed |
For now, this seems to be a workaround ( import screencapture from './screencapture.mp4';
<div
dangerouslySetInnerHTML={{
__html: `
<video
style="max-width: 80%"
controls
autoplay
muted
src="${screencapture}"
/>
`,
}}
/> Older versions of <div
dangerouslySetInnerHTML={{
__html: `
<video
style="max-width: 80%"
controls
autoplay
muted
src="./screencapture.mp4"
/>
`,
}}
/> |
@jxnblk Why was this closed? Has this been implemented in v3? |
I has not been implemented, but I'm planning on opening a new issue with a clearer specification |
Ok sounds good, thanks for the info. |
For videos etc.
The text was updated successfully, but these errors were encountered: