[Watch & Run] Add missing hooks #171
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Giovannini
force-pushed
the
feature/watch-and-run/add_missing_hooks
branch
from
7016e04
to
17faac6
Compare
| @@ -128,6 +140,12 @@ async function watcher(absolutePath: string, watchKind: WatchKind, watchAndRunCo | |||
| } | |||
|
|
|||
| const log = new Log('KitQL vite-plugin-watch-and-run') | |||
| const toCamel = (s: string): string => s | |||
There was a problem hiding this comment.
In the end, it may be better to directly use vite camelCase naming instead of snake uppercase naming here. Keeping it for compatibility.
There was a problem hiding this comment.
I don't mind doing a breaking change to be inlined with vite
It's also less code here and simpler.
Do you want to refactor?
|
I misunderstood something and this PR is not usable as it is (sorry for that). |
|
1/ Thx a lot for your contribution |
|
I've put up a pull request to add @Giovannini! 🎉 |
Giovannini
force-pushed
the
feature/watch-and-run/add_missing_hooks
branch
from
17faac6
to
8919e37
Compare
Giovannini
force-pushed
the
feature/watch-and-run/add_missing_hooks
branch
from
8919e37
to
2399672
Compare
Giovannini
force-pushed
the
feature/watch-and-run/add_missing_hooks
branch
3 times, most recently
from
4e2df57
to
f0cf593
Compare
|
Is there a README I did not see explaining the way to configure the dev environment ? |
Giovannini
force-pushed
the
feature/watch-and-run/add_missing_hooks
branch
from
578d17c
to
7154eab
Compare
I'm willing to improve 😅 |
Just the type errors actually. Locally, I just added a tsconfig file to the package I'm developping in so I can have some. |
…d-run/add_missing_hooks
Current implementation only watches 3 hooks: add, change and delete.
I needed to use the "ready" hook too in my app to run the command apppearing as soon as the vite server started. I just added the other hooks in the process: "addDir", "all", "error", "raw", "ready", "unlink", "unlinkDir".