test_ssl failures from weak certificate. Bug 2774 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimal fix is simply the update to selfsigned_pythontestdotnet.pem from Python core. See Python bug 36816. Also includes merges from latest 2.7 version of test_ssl, and separation of most jython variation into test_ssl_jy.py. This is to ease future maintenance and/or patches back into CPython. No new tests are skipped. Method test_algorithms() is deleted as per 2.7 and Python bug 25764, though it actually ran clean for me locally.
adamburkegh
changed the title
|
Thanks for looking at this @adamburkegh. I poked around with the same certs last weekend when I finally understood why |
|
Looks good to me. I moved a white space and added a news entry in your name. Apart from that, I'll push it via hg exactly as you submitted it. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimal fix is simply the update to selfsigned_pythontestdotnet.pem
from Python core. See Python bug 36816.
https://bugs.python.org/issue36816
Also includes merges from latest 2.7 version of test_ssl, and separation
of most jython variation into test_ssl_jy.py. This is to ease future
maintenance and/or patches back into CPython. No new tests are skipped.
Method test_algorithms() is deleted as per 2.7 and Python bug 25764,
though it actually ran clean for me locally. https://bugs.python.org/issue25764
This PR is cousin to
#136
#123
#142
Update: Travis CI has now run without any test_ssl failures.