Core: resetForm should also remove valid class from elements

Closes #1708
jquery-validation · Feb 24, 2016 · f07a267 · f07a267
1 parent e9fd71d
commit f07a267
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/core.js b/src/core.js
@@ -529,9 +529,12 @@ $.extend( $.validator, {
 				for ( i = 0; elements[ i ]; i++ ) {
 					this.settings.unhighlight.call( this, elements[ i ],
 						this.settings.errorClass, "" );
+					this.findByName( elements[ i ].name ).removeClass( this.settings.validClass );
 				}
 			} else {
-				elements.removeClass( this.settings.errorClass );
+				elements
+					.removeClass( this.settings.errorClass )
+					.removeClass( this.settings.validClass );
 			}
 		},
 

diff --git a/test/test.js b/test/test.js
@@ -976,10 +976,12 @@ test( "resetForm()", function() {
 	v.form();
 	errors( 2 );
 	ok( $( "#firstname" ).hasClass( "error" ) );
+	ok( $( "#something" ).hasClass( "valid" ) );
 	$( "#firstname" ).val( "hiy" );
 	v.resetForm();
 	errors( 0 );
 	ok( !$( "#firstname" ).hasClass( "error" ) );
+	ok( !$( "#something" ).hasClass( "valid" ) );
 	equal( $( "#firstname" ).val(), "", "form plugin is included, therefor resetForm must also reset inputs, not only errors" );
 } );