Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateDelegate not registered on focusin, focusout and keyup for checkables #1062

Closed
staabm opened this issue Mar 31, 2014 · 4 comments
Closed

validateDelegate not registered on focusin, focusout and keyup for checkables #1062

staabm opened this issue Mar 31, 2014 · 4 comments

Comments

@staabm
Copy link
Member

staabm commented Mar 31, 2014

validateDelegate not registered on focusin, focusout and keyup for checkables (radio,checkbox)?

the default implementation of e.g onfocusout atm filters for checkable elements, but this events are never triggered because of this...

created this issue, as requested in 5ba0df4#commitcomment-5854199
@staabm
Copy link
Member Author

staabm commented Mar 31, 2014

I will try to provide a PR for that.

staabm referenced this issue Mar 31, 2014
@jzaefferer
Update delegation selectors to get rid of pseudo-selectors in favor o…
5ba0df4 
…f qSA. Use type=email on main demo for some manual verification. Update changelog.
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 1, 2014
@staabm
Core: register validateDelegate also for checkables on focusin, focus…
6458317 
…out and keyup. fixes jquery-validation#1062.
@staabm staabm mentioned this issue Apr 1, 2014
Closed
@jzaefferer
Copy link
Collaborator

Is there actually a need to check those events on those elements? Isn't the click event enough to deal with them?

@staabm
Copy link
Member Author

staabm commented Apr 9, 2014

In our app we have checkboxes which are not validated when jumping through them with TAB. this is fixed by the related PR.

@staabm
Copy link
Member Author

staabm commented Apr 9, 2014

discussion continous in the PR.

@staabm staabm closed this as completed Apr 9, 2014
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
c53710c
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
a9c07c0
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
382df58
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
c1695d0
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
cf5b367
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
da4b63a
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
a060fa8
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
2636039
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 28, 2014
@staabm
added testcoverage for jquery-validation#1062.
fdaafb3
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 29, 2014
@staabm
added testcoverage for jquery-validation#1062.
ce2d471
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 29, 2014
@staabm
added testcoverage for jquery-validation#1062.
528ddcc
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 29, 2014
@staabm
Tests: added testcoverage for jquery-validation#1062.
748524d
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 29, 2014
@staabm
Tests: added testcoverage for jquery-validation#1062.
c74019e
staabm added a commit to staabm/jquery-validation that referenced this issue Apr 29, 2014
@staabm
Tests: added testcoverage for jquery-validation#1062.
250b608
staabm added a commit to staabm/jquery-validation that referenced this issue May 5, 2014
@staabm
Core: register validateDelegate also for checkables on focusin, focus…
a0f6fe9 
…out and keyup

fixes jquery-validation#1062
staabm added a commit to staabm/jquery-validation that referenced this issue May 5, 2014
@staabm
Core: register validateDelegate also for checkables on focusin, focus…
2b9097a 
…out and keyup

fixes jquery-validation#1062
staabm added a commit that referenced this issue May 20, 2014
@staabm @jzaefferer
Core: Register focusin, focusout and keyup also on radio/checkbox
d319a0d 
Fixes #1062
Closes #1065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: register validateDelegate also for checkables on focusin, focusout... staabm/jquery-validation
2 participants
@jzaefferer @staabm